Remove FileError interface

third_party/WebKit/Source/modules/filesystem/ErrorCallback.h

Index: third_party/WebKit/Source/modules/filesystem/ErrorCallback.h
diff --git a/third_party/WebKit/Source/modules/filesystem/ErrorCallback.h b/third_party/WebKit/Source/modules/filesystem/ErrorCallback.h
index 655b495dc46aea11538d923da5c9ee3c2855d402..f2cc1b1a4eff401163683a5f8c666b5b79266cff 100644
--- a/third_party/WebKit/Source/modules/filesystem/ErrorCallback.h
+++ b/third_party/WebKit/Source/modules/filesystem/ErrorCallback.h
@@ -31,17 +31,17 @@
 #ifndef ErrorCallback_h
 #define ErrorCallback_h
 
+#include "core/fileapi/FileError.h"
 #include "platform/heap/Handle.h"
 
 namespace blink {
 
-class FileError;
-
 class ErrorCallback : public GarbageCollectedFinalized<ErrorCallback> {
 public:
     virtual ~ErrorCallback() { }
     DEFINE_INLINE_VIRTUAL_TRACE() { }
-    virtual void handleEvent(FileError*) = 0;
+    virtual void handleEvent(DOMException*) = 0;
+    virtual void handleEvent(FileError::ErrorCode error) { handleEvent(FileError::createDOMException(error)); }

[foolip, 2016/06/23 12:04:48]

I don't think I quite understand the new role of the ErrorCallback interface.
It's a thing that's implemented by V8ErrorCallback so that our C++ can invoke
the callback in C++, but the new signature with the enum is for internal use and
in many cases handleEvent(DOMException*) is NOTREACHED(). Should these two
things be one thing (maybe I missed a necessary connection) or would it be
possible to have one thing that's purely for bindings and another for internal
use? It seems like this might get in the way in any refactoring of how callbacks
work, and I have thought about trying to make it such that WebIDL callback
interfaces and callback functions look the same to C++, as part of getting rid
of our bogus callback interfaces that are actually callback functions in the
specs.

[jsbell, 2016/06/23 19:44:29]

It is weird - I'll see if I can split it up.

It shows up where a sync API is implemented by calling the async API with e.g.
LocalErrorCallback which stashes the error code and then the sync API throws.

One approach would be to add ErrorCallbackBase which has only
handleEvent(FileError::ErrorCode). Internal uses subclass from this. Then we
could have a ScriptErrorCallback subclass that holds a the bindings-facing
ErrorCallback. Internal APIs would be changed to take ErrorCallbackBase,
script-facing APIs would wrap an ErrorCallback in ScriptErrorCallback.

 };
 
 } // namespace blink