third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.cpp - Issue 2040563002: Remove FileError interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.cpp

Issue 2040563002: Remove FileError interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fe-dep

Patch Set: Rebased, and closure annotations Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp ('k') | third_party/WebKit/Source/modules/filesystem/ErrorCallback.h » ('j') | third_party/WebKit/Source/modules/filesystem/ErrorCallback.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.cpp

diff --git a/third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.cpp b/third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.cpp

index 6fcb1880dca1a4a07d06ef566ccd9cc25a5a8f4c..ee2b24f1c49ef229a922d42a23752a51515f1c2f 100644

--- a/third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.cpp

+++ b/third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.cpp

@@ -73,9 +73,14 @@ public:

{

}

- void handleEvent(FileError* error) override

+ void handleEvent(DOMException* error) override

{

- m_reader->setError(error->code());

+ NOTREACHED();

+ }

+ void handleEvent(FileError::ErrorCode error) override

+ {

+ m_reader->setError(error);

}

DEFINE_INLINE_VIRTUAL_TRACE()