Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp

Issue 2040563002: Remove FileError interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fe-dep
Patch Set: Rebased, and closure annotations Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp
diff --git a/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp b/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp
index 02cf0279a00c21d85bf8e98633fe1e1338b4d68d..22a0e98af5a48dd527023fef741630ff2ba1f427 100644
--- a/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp
+++ b/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp
@@ -218,7 +218,7 @@ File* DOMFileSystemBase::createFile(const FileMetadata& metadata, const KURL& fi
void DOMFileSystemBase::getMetadata(const EntryBase* entry, MetadataCallback* successCallback, ErrorCallback* errorCallback, SynchronousType synchronousType)
{
if (!fileSystem()) {
- reportError(errorCallback, FileError::create(FileError::ABORT_ERR));
+ reportError(errorCallback, FileError::ABORT_ERR);
return;
}
@@ -259,13 +259,13 @@ static bool verifyAndGetDestinationPathForCopyOrMove(const EntryBase* source, En
void DOMFileSystemBase::move(const EntryBase* source, EntryBase* parent, const String& newName, EntryCallback* successCallback, ErrorCallback* errorCallback, SynchronousType synchronousType)
{
if (!fileSystem()) {
- reportError(errorCallback, FileError::create(FileError::ABORT_ERR));
+ reportError(errorCallback, FileError::ABORT_ERR);
return;
}
String destinationPath;
if (!verifyAndGetDestinationPathForCopyOrMove(source, parent, newName, destinationPath)) {
- reportError(errorCallback, FileError::create(FileError::INVALID_MODIFICATION_ERR));
+ reportError(errorCallback, FileError::INVALID_MODIFICATION_ERR);
return;
}
@@ -278,13 +278,13 @@ void DOMFileSystemBase::move(const EntryBase* source, EntryBase* parent, const S
void DOMFileSystemBase::copy(const EntryBase* source, EntryBase* parent, const String& newName, EntryCallback* successCallback, ErrorCallback* errorCallback, SynchronousType synchronousType)
{
if (!fileSystem()) {
- reportError(errorCallback, FileError::create(FileError::ABORT_ERR));
+ reportError(errorCallback, FileError::ABORT_ERR);
return;
}
String destinationPath;
if (!verifyAndGetDestinationPathForCopyOrMove(source, parent, newName, destinationPath)) {
- reportError(errorCallback, FileError::create(FileError::INVALID_MODIFICATION_ERR));
+ reportError(errorCallback, FileError::INVALID_MODIFICATION_ERR);
return;
}
@@ -297,14 +297,14 @@ void DOMFileSystemBase::copy(const EntryBase* source, EntryBase* parent, const S
void DOMFileSystemBase::remove(const EntryBase* entry, VoidCallback* successCallback, ErrorCallback* errorCallback, SynchronousType synchronousType)
{
if (!fileSystem()) {
- reportError(errorCallback, FileError::create(FileError::ABORT_ERR));
+ reportError(errorCallback, FileError::ABORT_ERR);
return;
}
ASSERT(entry);
// We don't allow calling remove() on the root directory.
if (entry->fullPath() == String(DOMFilePath::root)) {
- reportError(errorCallback, FileError::create(FileError::INVALID_MODIFICATION_ERR));
+ reportError(errorCallback, FileError::INVALID_MODIFICATION_ERR);
return;
}
@@ -317,14 +317,14 @@ void DOMFileSystemBase::remove(const EntryBase* entry, VoidCallback* successCall
void DOMFileSystemBase::removeRecursively(const EntryBase* entry, VoidCallback* successCallback, ErrorCallback* errorCallback, SynchronousType synchronousType)
{
if (!fileSystem()) {
- reportError(errorCallback, FileError::create(FileError::ABORT_ERR));
+ reportError(errorCallback, FileError::ABORT_ERR);
return;
}
ASSERT(entry && entry->isDirectory());
// We don't allow calling remove() on the root directory.
if (entry->fullPath() == String(DOMFilePath::root)) {
- reportError(errorCallback, FileError::create(FileError::INVALID_MODIFICATION_ERR));
+ reportError(errorCallback, FileError::INVALID_MODIFICATION_ERR);
return;
}
@@ -337,7 +337,7 @@ void DOMFileSystemBase::removeRecursively(const EntryBase* entry, VoidCallback*
void DOMFileSystemBase::getParent(const EntryBase* entry, EntryCallback* successCallback, ErrorCallback* errorCallback)
{
if (!fileSystem()) {
- reportError(errorCallback, FileError::create(FileError::ABORT_ERR));
+ reportError(errorCallback, FileError::ABORT_ERR);
return;
}
@@ -350,13 +350,13 @@ void DOMFileSystemBase::getParent(const EntryBase* entry, EntryCallback* success
void DOMFileSystemBase::getFile(const EntryBase* entry, const String& path, const FileSystemFlags& flags, EntryCallback* successCallback, ErrorCallback* errorCallback, SynchronousType synchronousType)
{
if (!fileSystem()) {
- reportError(errorCallback, FileError::create(FileError::ABORT_ERR));
+ reportError(errorCallback, FileError::ABORT_ERR);
return;
}
String absolutePath;
if (!pathToAbsolutePath(m_type, entry, path, absolutePath)) {
- reportError(errorCallback, FileError::create(FileError::INVALID_MODIFICATION_ERR));
+ reportError(errorCallback, FileError::INVALID_MODIFICATION_ERR);
return;
}
@@ -372,13 +372,13 @@ void DOMFileSystemBase::getFile(const EntryBase* entry, const String& path, cons
void DOMFileSystemBase::getDirectory(const EntryBase* entry, const String& path, const FileSystemFlags& flags, EntryCallback* successCallback, ErrorCallback* errorCallback, SynchronousType synchronousType)
{
if (!fileSystem()) {
- reportError(errorCallback, FileError::create(FileError::ABORT_ERR));
+ reportError(errorCallback, FileError::ABORT_ERR);
return;
}
String absolutePath;
if (!pathToAbsolutePath(m_type, entry, path, absolutePath)) {
- reportError(errorCallback, FileError::create(FileError::INVALID_MODIFICATION_ERR));
+ reportError(errorCallback, FileError::INVALID_MODIFICATION_ERR);
return;
}
@@ -394,7 +394,7 @@ void DOMFileSystemBase::getDirectory(const EntryBase* entry, const String& path,
int DOMFileSystemBase::readDirectory(DirectoryReaderBase* reader, const String& path, EntriesCallback* successCallback, ErrorCallback* errorCallback, SynchronousType synchronousType)
{
if (!fileSystem()) {
- reportError(errorCallback, FileError::create(FileError::ABORT_ERR));
+ reportError(errorCallback, FileError::ABORT_ERR);
return 0;
}

Powered by Google App Engine
This is Rietveld 408576698