third_party/WebKit/Source/modules/filesystem/FileWriter.cpp - Issue 2040563002: Remove FileError interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/FileWriter.cpp

Issue 2040563002: Remove FileError interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fe-dep

Patch Set: handleEvent -> invoke and other review nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/filesystem/FileWriter.cpp

diff --git a/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp b/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp

index 28b16dfa37fabae51d3981aa999f520f584cf6ad..e7a941d34db50e032ecf1b105bf1d1e154de2177 100644

--- a/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp

+++ b/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp

@@ -288,7 +288,7 @@ void FileWriter::signalCompletion(FileError::ErrorCode code)

m_readyState = DONE;

m_truncateLength = -1;

if (FileError::OK != code) {

- m_error = FileError::create(code);

+ m_error = FileError::createDOMException(code);

if (FileError::ABORT_ERR == code)

fireEvent(EventTypeNames::abort);

else

@@ -313,7 +313,7 @@ void FileWriter::setError(FileError::ErrorCode errorCode, ExceptionState& except

{

ASSERT(errorCode);

FileError::throwDOMException(exceptionState, errorCode);

- m_error = FileError::create(errorCode);

+ m_error = FileError::createDOMException(errorCode);

}

DEFINE_TRACE(FileWriter)