third_party/WebKit/Source/modules/filesystem/DirectoryReader.h - Issue 2040563002: Remove FileError interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/DirectoryReader.h

Issue 2040563002: Remove FileError interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fe-dep

Patch Set: handleEvent -> invoke and other review nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/filesystem/DirectoryReader.h

diff --git a/third_party/WebKit/Source/modules/filesystem/DirectoryReader.h b/third_party/WebKit/Source/modules/filesystem/DirectoryReader.h

index 45d8b1ba79b35447d6146f2f14d9a166c2f7f4e6..7eb8107dcdfc30917726dcce627dbac997dfe9f6 100644

--- a/third_party/WebKit/Source/modules/filesystem/DirectoryReader.h

+++ b/third_party/WebKit/Source/modules/filesystem/DirectoryReader.h

@@ -66,11 +66,11 @@ private:

void addEntries(const EntryHeapVector& entries);

- void onError(FileError*);

+ void onError(FileError::ErrorCode);

bool m_isReading;

EntryHeapVector m_entries;

- Member<FileError> m_error;

+ FileError::ErrorCode m_error = FileError::ErrorCode::OK;

Member<EntriesCallback> m_entriesCallback;

Member<ErrorCallback> m_errorCallback;

};