Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp

Issue 2040563002: Remove FileError interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fe-dep
Patch Set: handleEvent -> invoke and other review nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp
diff --git a/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp b/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp
index e57da4dc304375ac792950332294b35ecc4c4b28..59c21362a4967e98e1a4318dab6c109c917386f2 100644
--- a/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp
+++ b/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp
@@ -65,9 +65,9 @@ DOMFileSystemSync::~DOMFileSystemSync()
{
}
-void DOMFileSystemSync::reportError(ErrorCallback* errorCallback, FileError* fileError)
+void DOMFileSystemSync::reportError(ErrorCallbackBase* errorCallback, FileError::ErrorCode fileError)
{
- errorCallback->handleEvent(fileError);
+ errorCallback->invoke(fileError);
}
DirectoryEntrySync* DOMFileSystemSync::root()
@@ -181,17 +181,17 @@ private:
}
};
-class LocalErrorCallback final : public ErrorCallback {
+class LocalErrorCallback final : public ErrorCallbackBase {
public:
static LocalErrorCallback* create(FileError::ErrorCode& errorCode)
{
return new LocalErrorCallback(errorCode);
}
- void handleEvent(FileError* error) override
+ void invoke(FileError::ErrorCode error) override
{
- ASSERT(error->code() != FileError::OK);
- m_errorCode = error->code();
+ DCHECK_NE(error, FileError::OK);
+ m_errorCode = error;
}
private:

Powered by Google App Engine
This is Rietveld 408576698