third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h - Issue 2040563002: Remove FileError interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h

Issue 2040563002: Remove FileError interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fe-dep

Patch Set: handleEvent -> invoke and other review nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h

diff --git a/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h b/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h

index 4f403485a12c581fa05113e54b0b630e5d3f99c0..9d74798cff097cc1fc59b7f9f3f0ade880ea35b7 100644

--- a/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h

+++ b/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h

@@ -64,15 +64,15 @@ public:

// DOMFileSystemBase overrides.

void addPendingCallbacks() override;

void removePendingCallbacks() override;

- void reportError(ErrorCallback*, FileError*) override;

+ void reportError(ErrorCallbackBase*, FileError::ErrorCode) override;

- static void reportError(ExecutionContext*, ErrorCallback*, FileError*);

+ static void reportError(ExecutionContext*, ErrorCallbackBase*, FileError::ErrorCode);

// ActiveScriptWrappable overrides.

bool hasPendingActivity() const final;

- void createWriter(const FileEntry*, FileWriterCallback*, ErrorCallback*);

- void createFile(const FileEntry*, BlobCallback*, ErrorCallback*);

+ void createWriter(const FileEntry*, FileWriterCallback*, ErrorCallbackBase*);

+ void createFile(const FileEntry*, BlobCallback*, ErrorCallbackBase*);

// Schedule a callback. This should not cross threads (should be called on the same context thread).

static void scheduleCallback(ExecutionContext* executionContext, std::unique_ptr<ExecutionContextTask> task)