Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2040483003: Implement gfx::SelectionBound StructTraits (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, sadrul
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement gfx::SelectionBound StructTraits This will be needed by the cc::CompositorFrameMetadata StructTraits. BUG=611802 Committed: https://crrev.com/4d4083776dbe3a78def00bf8ef1b43098c32d930 Cr-Commit-Position: refs/heads/master@{#397772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -8 lines) Patch
M ui/gfx/mojo/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
A ui/gfx/mojo/selection_bound.mojom View 1 chunk +24 lines, -0 lines 0 comments Download
A ui/gfx/mojo/selection_bound.typemap View 1 chunk +9 lines, -0 lines 0 comments Download
A ui/gfx/mojo/selection_bound_struct_traits.h View 1 chunk +82 lines, -0 lines 0 comments Download
M ui/gfx/mojo/struct_traits_unittest.cc View 3 chunks +26 lines, -0 lines 0 comments Download
M ui/gfx/mojo/traits_test_service.mojom View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/mojo/transform_struct_traits.h View 2 chunks +3 lines, -3 lines 0 comments Download
D ui/gfx/mojo/typemaps.gni View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/gfx/typemaps.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Fady Samuel
PTAL Tom! Thanks
4 years, 6 months ago (2016-06-03 17:29:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040483003/1
4 years, 6 months ago (2016-06-03 17:29:52 UTC) #4
Fady Samuel
+sadrul@ for ui/ OWNER
4 years, 6 months ago (2016-06-03 17:33:49 UTC) #6
Tom Sepez
lgtm
4 years, 6 months ago (2016-06-03 17:43:49 UTC) #7
sadrul
lgtm
4 years, 6 months ago (2016-06-03 18:09:20 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-03 19:02:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040483003/1
4 years, 6 months ago (2016-06-03 19:04:53 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 19:10:51 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 19:13:11 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4d4083776dbe3a78def00bf8ef1b43098c32d930
Cr-Commit-Position: refs/heads/master@{#397772}

Powered by Google App Engine
This is Rietveld 408576698