Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2040243002: [turbofan] add more comments to compiler/graph-visualizer.cc. (Closed)

Created:
4 years, 6 months ago by bgeron
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] add more comments to compiler/graph-visualizer.cc. BUG= Committed: https://crrev.com/b6a15350b2838b61c468373e0bdfd225f0a56f12 Cr-Commit-Position: refs/heads/master@{#36824}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Polish #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/compiler/graph-visualizer.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
bgeron
Please take a look.
4 years, 6 months ago (2016-06-07 17:43:09 UTC) #2
Jarin
lgtm with nits. https://codereview.chromium.org/2040243002/diff/1/src/compiler/graph-visualizer.cc File src/compiler/graph-visualizer.cc (right): https://codereview.chromium.org/2040243002/diff/1/src/compiler/graph-visualizer.cc#newcode632 src/compiler/graph-visualizer.cc:632: // the node itself. Maybe you ...
4 years, 6 months ago (2016-06-07 19:35:31 UTC) #3
bgeron
Great feedback, thanks. https://codereview.chromium.org/2040243002/diff/1/src/compiler/graph-visualizer.cc File src/compiler/graph-visualizer.cc (right): https://codereview.chromium.org/2040243002/diff/1/src/compiler/graph-visualizer.cc#newcode632 src/compiler/graph-visualizer.cc:632: // the node itself. On 2016/06/07 ...
4 years, 6 months ago (2016-06-08 12:04:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040243002/20001
4 years, 6 months ago (2016-06-08 12:05:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040243002/20001
4 years, 6 months ago (2016-06-08 12:10:07 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-08 12:30:41 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 12:31:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b6a15350b2838b61c468373e0bdfd225f0a56f12
Cr-Commit-Position: refs/heads/master@{#36824}

Powered by Google App Engine
This is Rietveld 408576698