Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2039853002: Revert of [build] Fix default for target_arch (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach, Jarin, bgeron
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [build] Fix default for target_arch (patchset #1 id:1 of https://codereview.chromium.org/2040803005/ ) Reason for revert: sysroot logic breaks "make arm" Original issue's description: > [build] Fix default for target_arch > > Fix after https://codereview.chromium.org/2028623002/ > > BUG=chromium:474921, chromium:616032 > TBR=vogelheim@chromium.org, jochen@chromium.org > NOTRY=true > > Committed: https://crrev.com/9dcb67dd174fefc98f9c964ef54fed8fe6feb224 > Cr-Commit-Position: refs/heads/master@{#36733} TBR=vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921, chromium:616032 Committed: https://crrev.com/46d8293f50478be702ce00b6ae51f6491a552173 Cr-Commit-Position: refs/heads/master@{#36740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -19 lines) Patch
M gypfiles/standalone.gypi View 2 chunks +15 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [build] Fix default for target_arch
4 years, 6 months ago (2016-06-06 11:00:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039853002/1
4 years, 6 months ago (2016-06-06 11:00:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 11:00:36 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 11:01:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46d8293f50478be702ce00b6ae51f6491a552173
Cr-Commit-Position: refs/heads/master@{#36740}

Powered by Google App Engine
This is Rietveld 408576698