Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: ui/ozone/platform/drm/gpu/gbm_buffer.cc

Issue 2039813002: Add format modifier IDs for EGL_EXT_image_dma_buf_import extension (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add format modifier IDs for EGL_EXT_image_dma_buf_import extension Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/platform/drm/gpu/gbm_buffer.cc
diff --git a/ui/ozone/platform/drm/gpu/gbm_buffer.cc b/ui/ozone/platform/drm/gpu/gbm_buffer.cc
index 549b067782d11ffd1dc69067ccdc11ccab5d1224..cd8843728f53ba63867de25b3fc6e6ba140e4759 100644
--- a/ui/ozone/platform/drm/gpu/gbm_buffer.cc
+++ b/ui/ozone/platform/drm/gpu/gbm_buffer.cc
@@ -32,15 +32,13 @@ GbmBuffer::GbmBuffer(const scoped_refptr<GbmDevice>& gbm,
gfx::BufferUsage usage,
std::vector<base::ScopedFD>&& fds,
const gfx::Size& size,
- const std::vector<int>& strides,
- const std::vector<int>& offsets)
+ const std::vector<gfx::GbmBufferPlane>&& planes)
: GbmBufferBase(gbm, bo, format, usage),
format_(format),
usage_(usage),
fds_(std::move(fds)),
size_(size),
- strides_(strides),
- offsets_(offsets) {}
+ planes_(std::move(planes)) {}
GbmBuffer::~GbmBuffer() {
if (bo())
@@ -68,13 +66,18 @@ int GbmBuffer::GetFd(size_t plane) const {
}
int GbmBuffer::GetStride(size_t plane) const {
- DCHECK_LT(plane, strides_.size());
- return strides_[plane];
+ DCHECK_LT(plane, planes_.size());
+ return planes_[plane].stride;
}
int GbmBuffer::GetOffset(size_t plane) const {
- DCHECK_LT(plane, offsets_.size());
- return offsets_[plane];
+ DCHECK_LT(plane, planes_.size());
+ return planes_[plane].offset;
+}
+
+uint64_t GbmBuffer::GetFormatModifier(size_t plane) const {
+ DCHECK_LT(plane, planes_.size());
+ return planes_[plane].modifier;
}
// TODO(reveman): This should not be needed once crbug.com/597932 is fixed,
@@ -120,12 +123,11 @@ scoped_refptr<GbmBuffer> GbmBuffer::CreateBuffer(
}
std::vector<base::ScopedFD> fds;
fds.emplace_back(std::move(fd));
- std::vector<int> strides;
- strides.push_back(gbm_bo_get_stride(bo));
- std::vector<int> offsets;
- offsets.push_back(gbm_bo_get_plane_offset(bo, 0));
+ std::vector<gfx::GbmBufferPlane> planes;
+ planes.emplace_back(gbm_bo_get_stride(bo), gbm_bo_get_plane_offset(bo, 0),
+ gbm_bo_get_format_modifier(bo));
scoped_refptr<GbmBuffer> buffer(new GbmBuffer(
- gbm, bo, format, usage, std::move(fds), size, strides, offsets));
+ gbm, bo, format, usage, std::move(fds), size, std::move(planes)));
if (usage == gfx::BufferUsage::SCANOUT && !buffer->GetFramebufferId())
return nullptr;
@@ -138,16 +140,15 @@ scoped_refptr<GbmBuffer> GbmBuffer::CreateBufferFromFds(
gfx::BufferFormat format,
const gfx::Size& size,
std::vector<base::ScopedFD>&& fds,
- const std::vector<int>& strides,
- const std::vector<int>& offsets) {
+ const std::vector<gfx::GbmBufferPlane>&& planes) {
TRACE_EVENT2("drm", "GbmBuffer::CreateBufferFromFD", "device",
gbm->device_path().value(), "size", size.ToString());
- DCHECK_EQ(fds.size(), strides.size());
+ DCHECK_EQ(fds.size(), planes.size());
// TODO(reveman): Use gbm_bo_import after making buffers survive
// GPU process crashes. crbug.com/597932
return make_scoped_refptr(
new GbmBuffer(gbm, nullptr, format, gfx::BufferUsage::GPU_READ,
- std::move(fds), size, strides, offsets));
+ std::move(fds), size, std::move(planes)));
}
GbmPixmap::GbmPixmap(GbmSurfaceFactory* surface_manager,
@@ -174,8 +175,8 @@ gfx::NativePixmapHandle GbmPixmap::ExportHandle() {
handle.fds.emplace_back(
base::FileDescriptor(scoped_fd.release(), true /* auto_close */));
}
- handle.strides_and_offsets.emplace_back(buffer_->GetStride(i),
- buffer_->GetOffset(i));
+ handle.planes.emplace_back(buffer_->GetStride(i), buffer_->GetOffset(i),
+ buffer_->GetFormatModifier(i));
}
return handle;
}
@@ -207,6 +208,10 @@ int GbmPixmap::GetDmaBufOffset(size_t plane) const {
return buffer_->GetOffset(plane);
}
+uint64_t GbmPixmap::GetDmaBufModifier(size_t plane) const {
+ return buffer_->GetFormatModifier(plane);
+}
+
gfx::BufferFormat GbmPixmap::GetBufferFormat() const {
return buffer_->GetFormat();
}

Powered by Google App Engine
This is Rietveld 408576698