ui/ozone/platform/drm/gpu/drm_thread.h - Issue 2039813002: Add format modifier IDs for EGL_EXT_image_dma_buf_import extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/ozone/platform/drm/gpu/drm_thread.h

Issue 2039813002: Add format modifier IDs for EGL_EXT_image_dma_buf_import extension (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add format modifier IDs for EGL_EXT_image_dma_buf_import extension Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/gl/gl_image_ozone_native_pixmap.cc ('K') | « ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc ('k') | ui/ozone/platform/drm/gpu/drm_thread.cc » ('j') | ui/ozone/platform/drm/gpu/gbm_buffer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/ozone/platform/drm/gpu/drm_thread.h

diff --git a/ui/ozone/platform/drm/gpu/drm_thread.h b/ui/ozone/platform/drm/gpu/drm_thread.h

index 56e566d3902b3e3c10321bf4b0a4f16f58b0385b..328acb17cba93902ac00a8d1e6600b102286577f 100644

--- a/ui/ozone/platform/drm/gpu/drm_thread.h

+++ b/ui/ozone/platform/drm/gpu/drm_thread.h

@@ -62,8 +62,7 @@ class DrmThread : public base::Thread {

void CreateBufferFromFds(const gfx::Size& size,

gfx::BufferFormat format,

std::vector<base::ScopedFD>&& fds,

- std::vector<int> strides,

- std::vector<int> offsets,

+ std::vector<gfx::GbmBufferPlane>&& planes,

Daniele Castagna 2016/06/15 03:50:20 just const ref is fine.

vinceh 2016/06/15 04:35:18 OK. Will fix.

scoped_refptr<GbmBuffer>* buffer);

void GetScanoutFormats(gfx::AcceleratedWidget widget,