Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2039743003: Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA. (Closed)

Created:
4 years, 6 months ago by horo
Modified:
4 years, 6 months ago
CC:
asvitkine+watch_chromium.org, blink-worker-reviews_chromium.org, chasej+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, horo+watch_chromium.org, iclelland+watch_chromium.org, jam, jkarlin+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, michaeln, nhiroki, Peter Beverloo, pfeldman, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA. We can measure the effect of the speculatively launch of Service Workers on UI-events by this metric. BUG=616502 Committed: https://crrev.com/dc54e7bda1c339def75e712235e166ab575d41b7 Cr-Commit-Position: refs/heads/master@{#398814}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : move GetWorkerPreparationSuffix #

Total comments: 17

Patch Set 4 : incorporated falken's comment #

Total comments: 8

Patch Set 5 : #

Total comments: 6

Patch Set 6 : #

Total comments: 4

Patch Set 7 : updated the comments #

Total comments: 4

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+467 lines, -266 lines) Patch
M content/browser/background_sync/background_sync_manager.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 1 2 3 4 5 6 7 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.h View 1 2 3 9 chunks +19 lines, -13 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 1 2 3 4 22 chunks +66 lines, -53 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 1 2 3 21 chunks +33 lines, -32 lines 0 comments Download
A content/browser/service_worker/embedded_worker_status.h View 1 chunk +19 lines, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 2 3 7 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 1 2 3 7 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_observer.h View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_context_watcher.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_context_watcher.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 2 3 7 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 1 2 3 7 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_info.h View 1 2 3 4 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_info.cc View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 1 2 3 7 13 chunks +19 lines, -19 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.h View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.cc View 1 2 3 4 3 chunks +40 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 2 3 7 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_register_job.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_registration.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 1 2 3 4 3 chunks +5 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 1 2 3 4 5 6 3 chunks +40 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 2 3 8 chunks +12 lines, -14 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 2 3 4 32 chunks +63 lines, -47 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 2 3 7 40 chunks +51 lines, -52 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 6 7 2 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (11 generated)
horo
falken@ Could you please review this?
4 years, 6 months ago (2016-06-06 10:53:56 UTC) #2
falken
https://codereview.chromium.org/2039743003/diff/40001/content/browser/service_worker/embedded_worker_instance.h File content/browser/service_worker/embedded_worker_instance.h (right): https://codereview.chromium.org/2039743003/diff/40001/content/browser/service_worker/embedded_worker_instance.h#newcode55 content/browser/service_worker/embedded_worker_instance.h:55: typedef EmbeddedWorkerStatus Status; I think it's now: using EmbeddedWorkerStatus ...
4 years, 6 months ago (2016-06-07 03:46:12 UTC) #4
horo
https://codereview.chromium.org/2039743003/diff/40001/content/browser/service_worker/embedded_worker_instance.h File content/browser/service_worker/embedded_worker_instance.h (right): https://codereview.chromium.org/2039743003/diff/40001/content/browser/service_worker/embedded_worker_instance.h#newcode55 content/browser/service_worker/embedded_worker_instance.h:55: typedef EmbeddedWorkerStatus Status; On 2016/06/07 03:46:12, falken wrote: > ...
4 years, 6 months ago (2016-06-07 05:58:12 UTC) #5
falken
https://codereview.chromium.org/2039743003/diff/60001/content/browser/service_worker/embedded_worker_instance.cc File content/browser/service_worker/embedded_worker_instance.cc (right): https://codereview.chromium.org/2039743003/diff/60001/content/browser/service_worker/embedded_worker_instance.cc#newcode846 content/browser/service_worker/embedded_worker_instance.cc:846: NOTREACHED(); curious: why remove the status output? https://codereview.chromium.org/2039743003/diff/60001/content/browser/service_worker/service_worker_url_request_job.cc File ...
4 years, 6 months ago (2016-06-07 06:20:30 UTC) #6
horo
https://codereview.chromium.org/2039743003/diff/60001/content/browser/service_worker/embedded_worker_instance.cc File content/browser/service_worker/embedded_worker_instance.cc (right): https://codereview.chromium.org/2039743003/diff/60001/content/browser/service_worker/embedded_worker_instance.cc#newcode846 content/browser/service_worker/embedded_worker_instance.cc:846: NOTREACHED(); On 2016/06/07 06:20:30, falken wrote: > curious: why ...
4 years, 6 months ago (2016-06-07 06:58:48 UTC) #7
falken
lgtm, thanks https://codereview.chromium.org/2039743003/diff/80001/content/browser/service_worker/service_worker_url_request_job.cc File content/browser/service_worker/service_worker_url_request_job.cc (right): https://codereview.chromium.org/2039743003/diff/80001/content/browser/service_worker/service_worker_url_request_job.cc#newcode643 content/browser/service_worker/service_worker_url_request_job.cc:643: !ServiceWorkerMetrics::ShouldExcludeURLFromHistogram(request()->url())) { OK I finally understand this. ...
4 years, 6 months ago (2016-06-07 07:33:48 UTC) #8
horo
https://codereview.chromium.org/2039743003/diff/80001/content/browser/service_worker/service_worker_url_request_job.cc File content/browser/service_worker/service_worker_url_request_job.cc (right): https://codereview.chromium.org/2039743003/diff/80001/content/browser/service_worker/service_worker_url_request_job.cc#newcode643 content/browser/service_worker/service_worker_url_request_job.cc:643: !ServiceWorkerMetrics::ShouldExcludeURLFromHistogram(request()->url())) { On 2016/06/07 07:33:48, falken wrote: > OK ...
4 years, 6 months ago (2016-06-07 07:54:59 UTC) #9
horo
jkarlin@ Please review content/browser/background_sync/background_sync_manager.cc. yurys@ Please review content/browser/devtools/protocol/service_worker_handler.cc. mpearson@ Please review histograms.xml.
4 years, 6 months ago (2016-06-07 07:58:07 UTC) #11
jkarlin
background_sync/ lgtm
4 years, 6 months ago (2016-06-07 10:49:50 UTC) #12
Mark P
Afraid to say it, but you histograms.xml needs a lot of clarification. https://codereview.chromium.org/2039743003/diff/100001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml ...
4 years, 6 months ago (2016-06-07 17:44:10 UTC) #14
horo
https://codereview.chromium.org/2039743003/diff/100001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2039743003/diff/100001/tools/metrics/histograms/histograms.xml#newcode49562 tools/metrics/histograms/histograms.xml:49562: + started to send a FetchEvent request for a ...
4 years, 6 months ago (2016-06-08 04:13:23 UTC) #15
Mark P
thank you for the extensive revisions. histograms.xml lgtm, baring some minor comments below --mark https://codereview.chromium.org/2039743003/diff/120001/tools/metrics/histograms/histograms.xml ...
4 years, 6 months ago (2016-06-08 20:08:46 UTC) #16
horo
Thank you! https://codereview.chromium.org/2039743003/diff/120001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2039743003/diff/120001/tools/metrics/histograms/histograms.xml#newcode49562 tools/metrics/histograms/histograms.xml:49562: + to which to dispatch a FetchEvent ...
4 years, 6 months ago (2016-06-08 22:54:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039743003/140001
4 years, 6 months ago (2016-06-08 22:55:38 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/197550)
4 years, 6 months ago (2016-06-08 23:04:40 UTC) #22
horo
dgozman@ Could you please reivew content/browser/devtools/protocol/service_worker_handler.cc?
4 years, 6 months ago (2016-06-09 05:49:47 UTC) #23
pfeldman
devtools lgtm
4 years, 6 months ago (2016-06-09 06:00:02 UTC) #25
horo
Thank you
4 years, 6 months ago (2016-06-09 06:06:04 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039743003/140001
4 years, 6 months ago (2016-06-09 06:39:53 UTC) #28
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 6 months ago (2016-06-09 08:16:59 UTC) #30
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 08:18:27 UTC) #32
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/dc54e7bda1c339def75e712235e166ab575d41b7
Cr-Commit-Position: refs/heads/master@{#398814}

Powered by Google App Engine
This is Rietveld 408576698