content/browser/service_worker/service_worker_dispatcher_host_unittest.cc - Issue 2039743003: Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

Issue 2039743003: Introduce ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time UMA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | content/browser/service_worker/service_worker_fetch_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

index 376ffa218fa6cd075a66fd4fa14b662340c75310..93613af4ea6edac4c095c7bc1ffab204dc50a5db 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

@@ -16,6 +16,7 @@

#include "content/browser/message_port_service.h"

#include "content/browser/service_worker/embedded_worker_instance.h"

#include "content/browser/service_worker/embedded_worker_registry.h"

+#include "content/browser/service_worker/embedded_worker_status.h"

#include "content/browser/service_worker/embedded_worker_test_helper.h"

#include "content/browser/service_worker/service_worker_context_core.h"

#include "content/browser/service_worker/service_worker_context_wrapper.h"

@@ -632,14 +633,14 @@ TEST_F(ServiceWorkerDispatcherHostTest, CleanupOnRendererCrash) {

EXPECT_EQ(SERVICE_WORKER_OK, status);

EXPECT_TRUE(context()->GetProviderHost(process_id, provider_id));

- EXPECT_EQ(ServiceWorkerVersion::RUNNING, version_->running_status());

+ EXPECT_EQ(EmbeddedWorkerStatus::RUNNING, version_->running_status());

// Simulate the render process crashing.

dispatcher_host_->OnFilterRemoved();

// The dispatcher host should clean up the state from the process.

EXPECT_FALSE(context()->GetProviderHost(process_id, provider_id));

- EXPECT_EQ(ServiceWorkerVersion::STOPPED, version_->running_status());

+ EXPECT_EQ(EmbeddedWorkerStatus::STOPPED, version_->running_status());

// We should be able to hook up a new dispatcher host although the old object

// is not yet destroyed. This is what the browser does when reusing a crashed