Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2039613002: Add a debug view to the browser that allows various navigation features to be used. (Closed)

Created:
4 years, 6 months ago by Ben Goodger (Google)
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a debug view to the browser that allows various navigation features to be used. Adds a simple Interstitial API. R=sky@chromium.org Committed: https://crrev.com/6dfe6172d9901e35b17990dd4d1423055ed903ca Cr-Commit-Position: refs/heads/master@{#397866}

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -5 lines) Patch
M mash/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mash/browser/browser.cc View 1 7 chunks +39 lines, -5 lines 0 comments Download
A mash/browser/debug_view.h View 1 1 chunk +51 lines, -0 lines 0 comments Download
A mash/browser/debug_view.cc View 1 chunk +68 lines, -0 lines 0 comments Download
M services/navigation/public/interfaces/view.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M services/navigation/view_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M services/navigation/view_impl.cc View 1 3 chunks +37 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Ben Goodger (Google)
4 years, 6 months ago (2016-06-03 21:49:10 UTC) #1
sky
Assuming no leaks, LGTM https://codereview.chromium.org/2039613002/diff/1/mash/browser/browser.cc File mash/browser/browser.cc (right): https://codereview.chromium.org/2039613002/diff/1/mash/browser/browser.cc#newcode188 mash/browser/browser.cc:188: else if (sender == debug_button_) ...
4 years, 6 months ago (2016-06-03 22:24:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039613002/20001
4 years, 6 months ago (2016-06-03 23:05:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-04 00:50:45 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 00:51:58 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6dfe6172d9901e35b17990dd4d1423055ed903ca
Cr-Commit-Position: refs/heads/master@{#397866}

Powered by Google App Engine
This is Rietveld 408576698