Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2038143003: Support link hovering. (Closed)

Created:
4 years, 6 months ago by Ben Goodger (Google)
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@clean
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support link hovering. R=sky@chromium.org Committed: https://crrev.com/fe1c233bb2898336024c8d38c1c2f35e2f007545 Cr-Commit-Position: refs/heads/master@{#398091}

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M mash/browser/browser.cc View 3 chunks +10 lines, -1 line 0 comments Download
M mash/webtest/webtest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/navigation/navigation_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M services/navigation/public/interfaces/view.mojom View 1 2 chunks +6 lines, -0 lines 0 comments Download
M services/navigation/view_impl.h View 4 chunks +6 lines, -0 lines 0 comments Download
M services/navigation/view_impl.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2046723002 Patch 1

Messages

Total messages: 8 (3 generated)
Ben Goodger (Google)
4 years, 6 months ago (2016-06-03 23:07:39 UTC) #1
sky
LGTM https://codereview.chromium.org/2038143003/diff/1/services/navigation/public/interfaces/view.mojom File services/navigation/public/interfaces/view.mojom (right): https://codereview.chromium.org/2038143003/diff/1/services/navigation/public/interfaces/view.mojom#newcode48 services/navigation/public/interfaces/view.mojom:48: SetResizerSize(gfx.mojom.Size size); nit: document what a resizer is.
4 years, 6 months ago (2016-06-03 23:17:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038143003/20001
4 years, 6 months ago (2016-06-06 18:14:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 19:27:52 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 19:30:27 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fe1c233bb2898336024c8d38c1c2f35e2f007545
Cr-Commit-Position: refs/heads/master@{#398091}

Powered by Google App Engine
This is Rietveld 408576698