chrome/browser/resources/md_feedback/feedback.html - Issue 2039593002: [Md Feedback] Add initial content/strings to feedback-container element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_feedback/feedback.html

Issue 2039593002: [Md Feedback] Add initial content/strings to feedback-container element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_feedback/feedback.css ('K') | « chrome/browser/resources/md_feedback/feedback.css ('k') | chrome/browser/resources/md_feedback/feedback_container.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_feedback/feedback.html

diff --git a/chrome/browser/resources/md_feedback/feedback.html b/chrome/browser/resources/md_feedback/feedback.html

index d687394e84b25682dacdc56fc207ef1921374c6f..40789aa7c6589fc04ffd69d51d67b39119e6019c 100644

--- a/chrome/browser/resources/md_feedback/feedback.html

+++ b/chrome/browser/resources/md_feedback/feedback.html

@@ -1,8 +1,17 @@

<!DOCTYPE HTML>

+<html i18n-values="dir:textdirection;lang:language">

Dan Beam 2016/06/08 00:29:51 nit: consider <html dir="${textdirection}" lang="$

apacible 2016/06/09 18:41:04 Is this different from $i18n{textdirection}? I loo

Dan Beam 2016/06/09 18:57:47 sorry, I meant $i18n{textdirection}, you're right

apacible 2016/06/09 21:01:35 Done.

<html>

<head>

+ <meta charset="utf-8">

+ <link rel="stylesheet" href="chrome://resources/css/roboto.css">

+ <link rel="stylesheet" href="feedback.css">

+ <link rel="import" href="chrome://resources/html/load_time_data.html">

+ <script src="strings.js"></script>

+ <link rel="import" href="feedback_container.html">

</head>

<body>

- Feedback

+ <feedback-container></feedback-container>

+ <link rel="import" href="chrome://resources/html/i18n_template.html">

</body>

-</html>

+</html>