chrome/browser/resources/md_feedback/feedback.html - Issue 2039593002: [Md Feedback] Add initial content/strings to feedback-container element.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_feedback/feedback.html

Issue 2039593002: [Md Feedback] Add initial content/strings to feedback-container element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_feedback/feedback.css ('K') | « chrome/browser/resources/md_feedback/feedback.css ('k') | chrome/browser/resources/md_feedback/feedback_container.css » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

	2 <html i18n-values="dir:textdirection;lang:language">
	Dan Beam 2016/06/08 00:29:51 nit: consider <html dir="${textdirection}" lang="$ nit: consider <html dir="${textdirection}" lang="${language}"> instead apacible 2016/06/09 18:41:04 Is this different from $i18n{textdirection}? I loo Show quoted text On 2016/06/08 00:29:51, Dan Beam wrote: > nit: consider <html dir="${textdirection}" lang="${language}"> instead Is this different from $i18n{textdirection}? I looked for some other usages of this but didn't find any. Dan Beam 2016/06/09 18:57:47 sorry, I meant $i18n{textdirection}, you're right Show quoted text On 2016/06/09 18:41:04, apacible wrote: > On 2016/06/08 00:29:51, Dan Beam wrote: > > nit: consider <html dir="${textdirection}" lang="${language}"> instead > > Is this different from $i18n{textdirection}? I looked for some other usages of > this but didn't find any. sorry, I meant $i18n{textdirection}, you're right apacible 2016/06/09 21:01:35 Done. Show quoted text On 2016/06/09 18:57:47, Dan Beam wrote: > On 2016/06/09 18:41:04, apacible wrote: > > On 2016/06/08 00:29:51, Dan Beam wrote: > > > nit: consider <html dir="${textdirection}" lang="${language}"> instead > > > > Is this different from $i18n{textdirection}? I looked for some other usages of > > this but didn't find any. > > sorry, I meant $i18n{textdirection}, you're right Done.
2 <html>	3 <html>

3 <head>	4 <head>

	5 <meta charset="utf-8">

	6

	7 <link rel="stylesheet" href="chrome://resources/css/roboto.css">

	8 <link rel="stylesheet" href="feedback.css">

	9 <link rel="import" href="chrome://resources/html/load_time_data.html">

	10 <script src="strings.js"></script>

	11 <link rel="import" href="feedback_container.html">

4 </head>	12 </head>

5 <body>	13 <body>

6 Feedback	14 <feedback-container></feedback-container>

	15 <link rel="import" href="chrome://resources/html/i18n_template.html">

7 </body>	16 </body>

8 </html>	17 </html>

OLD	NEW