Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2039553002: [json] Repair JSON.parse regression with non-sequential strings. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[json] Repair JSON.parse regression with non-sequential strings. Make sure to flatten strings first in JSON.parse() builtins, otherwise we always hit the slow path for non-sequential strings, i.e. for cons strings. Also don't create any arguments adaptor frames for JSON.parse() as the C++ builtin can handle any number of inputs properly. R=yangguo@chromium.org Committed: https://crrev.com/e3c3be36eee9aa413fa309d5df88a2f18f24d2a1 Cr-Commit-Position: refs/heads/master@{#36722}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 1 comment Download
M src/builtins.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-03 18:10:46 UTC) #1
Yang
https://codereview.chromium.org/2039553002/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/2039553002/diff/1/src/bootstrapper.cc#newcode1608 src/bootstrapper.cc:1608: true); do we need to change this for JSON.stringify ...
4 years, 6 months ago (2016-06-03 18:22:00 UTC) #2
Yang
On 2016/06/03 18:22:00, Yang wrote: > https://codereview.chromium.org/2039553002/diff/1/src/bootstrapper.cc > File src/bootstrapper.cc (right): > > https://codereview.chromium.org/2039553002/diff/1/src/bootstrapper.cc#newcode1608 > ...
4 years, 6 months ago (2016-06-03 18:22:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039553002/1
4 years, 6 months ago (2016-06-03 18:38:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 18:41:02 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 18:42:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3c3be36eee9aa413fa309d5df88a2f18f24d2a1
Cr-Commit-Position: refs/heads/master@{#36722}

Powered by Google App Engine
This is Rietveld 408576698