src/bootstrapper.cc - Issue 2039553002: [json] Repair JSON.parse regression with non-sequential strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.cc

Issue 2039553002: [json] Repair JSON.parse regression with non-sequential strings. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/bootstrapper.cc

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc

index 3125c59de374704c970d18886efca4d3e253d873..3541172b7f95936f59be0e1eea331a215d6eaef3 100644

--- a/src/bootstrapper.cc

+++ b/src/bootstrapper.cc

@@ -1603,7 +1603,7 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,

Handle<JSObject> json_object = factory->NewJSObject(cons, TENURED);

DCHECK(json_object->IsJSObject());

JSObject::AddProperty(global, name, json_object, DONT_ENUM);

- SimpleInstallFunction(json_object, "parse", Builtins::kJsonParse, 2, true);

+ SimpleInstallFunction(json_object, "parse", Builtins::kJsonParse, 2, false);

SimpleInstallFunction(json_object, "stringify", Builtins::kJsonStringify, 3,

true);

Yang 2016/06/03 18:22:00 do we need to change this for JSON.stringify too?

JSObject::AddProperty(

« no previous file with comments | « no previous file | src/builtins.cc » ('j') | no next file with comments »