Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2039533002: [chromedriver] Check if chrome_path is None (Android uses package name instead). (Closed)

Created:
4 years, 6 months ago by samuong
Modified:
4 years, 6 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Check if chrome_path is None (Android uses package name instead). BUG= TBR=stgao@chromium.org Committed: https://crrev.com/5a00559c13f70af21a71117ea9a2f7a287210337 Cr-Commit-Position: refs/heads/master@{#397753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M chrome/test/chromedriver/test/run_java_tests.py View 1 chunk +10 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039533002/1
4 years, 6 months ago (2016-06-03 17:17:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 18:03:17 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5a00559c13f70af21a71117ea9a2f7a287210337 Cr-Commit-Position: refs/heads/master@{#397753}
4 years, 6 months ago (2016-06-03 18:05:08 UTC) #5
stgao
4 years, 6 months ago (2016-06-03 19:17:46 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698