Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8641)

Unified Diff: chrome/test/chromedriver/test/run_java_tests.py

Issue 2039533002: [chromedriver] Check if chrome_path is None (Android uses package name instead). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/test/run_java_tests.py
diff --git a/chrome/test/chromedriver/test/run_java_tests.py b/chrome/test/chromedriver/test/run_java_tests.py
index 19e8558dd788db347251926e7ed9218049e85003..cdacd01bca1f000acb92216c4907cc384b2ed3bc 100755
--- a/chrome/test/chromedriver/test/run_java_tests.py
+++ b/chrome/test/chromedriver/test/run_java_tests.py
@@ -98,20 +98,19 @@ def _Run(java_tests_src_dir, test_filter,
shutil.copyfile(os.path.join(java_tests_src_dir, test_jar),
os.path.join(test_dir, test_jar))
- if util.IsLinux() and not util.Is64Bit():
- # Workaround for crbug.com/611886
- chrome_wrapper_path = os.path.join(test_dir, 'chrome-wrapper-no-sandbox')
- with open(chrome_wrapper_path, 'w') as f:
- f.write('#!/bin/sh\n')
- f.write('exec %s --no-sandbox "$@"\n' % os.path.abspath(chrome_path))
- st = os.stat(chrome_wrapper_path)
- os.chmod(chrome_wrapper_path, st.st_mode | stat.S_IEXEC)
- else:
- chrome_wrapper_path = os.path.abspath(chrome_path)
-
sys_props = ['selenium.browser=chrome',
'webdriver.chrome.driver=' + os.path.abspath(chromedriver_path)]
if chrome_path:
+ if util.IsLinux() and not util.Is64Bit():
+ # Workaround for crbug.com/611886
+ chrome_wrapper_path = os.path.join(test_dir, 'chrome-wrapper-no-sandbox')
+ with open(chrome_wrapper_path, 'w') as f:
+ f.write('#!/bin/sh\n')
+ f.write('exec %s --no-sandbox "$@"\n' % os.path.abspath(chrome_path))
+ st = os.stat(chrome_wrapper_path)
+ os.chmod(chrome_wrapper_path, st.st_mode | stat.S_IEXEC)
+ else:
+ chrome_wrapper_path = os.path.abspath(chrome_path)
sys_props += ['webdriver.chrome.binary=' + chrome_wrapper_path]
if log_path:
sys_props += ['webdriver.chrome.logfile=' + log_path]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698