Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6972)

Unified Diff: chrome/browser/ui/views/toolbar/app_menu_button.cc

Issue 2039403002: Renamed AppMenuBadgeController to AppMenuIconController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reword comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/app_menu_button.cc
diff --git a/chrome/browser/ui/views/toolbar/app_menu_button.cc b/chrome/browser/ui/views/toolbar/app_menu_button.cc
index 482d37056e808c68bc0fdf805f16326e3ab17186..4517131eb90e12a42e0fc109954419c85b74e439 100644
--- a/chrome/browser/ui/views/toolbar/app_menu_button.cc
+++ b/chrome/browser/ui/views/toolbar/app_menu_button.cc
@@ -38,7 +38,7 @@ bool AppMenuButton::g_open_app_immediately_for_testing = false;
AppMenuButton::AppMenuButton(ToolbarView* toolbar_view)
: views::MenuButton(base::string16(), toolbar_view, false),
severity_(AppMenuIconPainter::SEVERITY_NONE),
- type_(AppMenuBadgeController::BadgeType::NONE),
+ type_(AppMenuIconController::IconType::NONE),
toolbar_view_(toolbar_view),
allow_extension_dragging_(
extensions::FeatureSwitch::extension_action_redesign()->IsEnabled()),
@@ -52,7 +52,7 @@ AppMenuButton::AppMenuButton(ToolbarView* toolbar_view)
AppMenuButton::~AppMenuButton() {}
-void AppMenuButton::SetSeverity(AppMenuBadgeController::BadgeType type,
+void AppMenuButton::SetSeverity(AppMenuIconController::IconType type,
AppMenuIconPainter::Severity severity,
bool animate) {
if (ui::MaterialDesignController::IsModeMaterial()) {
@@ -157,17 +157,17 @@ void AppMenuButton::UpdateIcon() {
gfx::VectorIconId icon_id = gfx::VectorIconId::VECTOR_ICON_NONE;
switch (type_) {
- case AppMenuBadgeController::BadgeType::NONE:
+ case AppMenuIconController::IconType::NONE:
icon_id = gfx::VectorIconId::BROWSER_TOOLS;
DCHECK_EQ(severity_, AppMenuIconPainter::SEVERITY_NONE);
break;
- case AppMenuBadgeController::BadgeType::UPGRADE_NOTIFICATION:
+ case AppMenuIconController::IconType::UPGRADE_NOTIFICATION:
icon_id = gfx::VectorIconId::BROWSER_TOOLS_UPDATE;
break;
- case AppMenuBadgeController::BadgeType::GLOBAL_ERROR:
+ case AppMenuIconController::IconType::GLOBAL_ERROR:
icon_id = gfx::VectorIconId::BROWSER_TOOLS_ERROR;
break;
- case AppMenuBadgeController::BadgeType::INCOMPATIBILITY_WARNING:
+ case AppMenuIconController::IconType::INCOMPATIBILITY_WARNING:
icon_id = gfx::VectorIconId::BROWSER_TOOLS_WARNING;
break;
}

Powered by Google App Engine
This is Rietveld 408576698