Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/browser/ui/views/toolbar/app_menu_button.cc

Issue 2039403002: Renamed AppMenuBadgeController to AppMenuIconController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reword comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/toolbar/app_menu_button.h" 5 #include "chrome/browser/ui/views/toolbar/app_menu_button.h"
6 6
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "base/threading/thread_task_runner_handle.h" 10 #include "base/threading/thread_task_runner_handle.h"
(...skipping 20 matching lines...) Expand all
31 #include "ui/views/controls/menu/menu_listener.h" 31 #include "ui/views/controls/menu/menu_listener.h"
32 #include "ui/views/metrics.h" 32 #include "ui/views/metrics.h"
33 #include "ui/views/painter.h" 33 #include "ui/views/painter.h"
34 34
35 // static 35 // static
36 bool AppMenuButton::g_open_app_immediately_for_testing = false; 36 bool AppMenuButton::g_open_app_immediately_for_testing = false;
37 37
38 AppMenuButton::AppMenuButton(ToolbarView* toolbar_view) 38 AppMenuButton::AppMenuButton(ToolbarView* toolbar_view)
39 : views::MenuButton(base::string16(), toolbar_view, false), 39 : views::MenuButton(base::string16(), toolbar_view, false),
40 severity_(AppMenuIconPainter::SEVERITY_NONE), 40 severity_(AppMenuIconPainter::SEVERITY_NONE),
41 type_(AppMenuBadgeController::BadgeType::NONE), 41 type_(AppMenuIconController::IconType::NONE),
42 toolbar_view_(toolbar_view), 42 toolbar_view_(toolbar_view),
43 allow_extension_dragging_( 43 allow_extension_dragging_(
44 extensions::FeatureSwitch::extension_action_redesign()->IsEnabled()), 44 extensions::FeatureSwitch::extension_action_redesign()->IsEnabled()),
45 margin_trailing_(0), 45 margin_trailing_(0),
46 weak_factory_(this) { 46 weak_factory_(this) {
47 set_ink_drop_delegate( 47 set_ink_drop_delegate(
48 base::WrapUnique(new views::ButtonInkDropDelegate(this, this))); 48 base::WrapUnique(new views::ButtonInkDropDelegate(this, this)));
49 if (!ui::MaterialDesignController::IsModeMaterial()) 49 if (!ui::MaterialDesignController::IsModeMaterial())
50 icon_painter_.reset(new AppMenuIconPainter(this)); 50 icon_painter_.reset(new AppMenuIconPainter(this));
51 } 51 }
52 52
53 AppMenuButton::~AppMenuButton() {} 53 AppMenuButton::~AppMenuButton() {}
54 54
55 void AppMenuButton::SetSeverity(AppMenuBadgeController::BadgeType type, 55 void AppMenuButton::SetSeverity(AppMenuIconController::IconType type,
56 AppMenuIconPainter::Severity severity, 56 AppMenuIconPainter::Severity severity,
57 bool animate) { 57 bool animate) {
58 if (ui::MaterialDesignController::IsModeMaterial()) { 58 if (ui::MaterialDesignController::IsModeMaterial()) {
59 severity_ = severity; 59 severity_ = severity;
60 type_ = type; 60 type_ = type;
61 UpdateIcon(); 61 UpdateIcon();
62 return; 62 return;
63 } 63 }
64 64
65 icon_painter_->SetSeverity(severity, animate); 65 icon_painter_->SetSeverity(severity, animate);
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 case AppMenuIconPainter::SEVERITY_MEDIUM: 150 case AppMenuIconPainter::SEVERITY_MEDIUM:
151 color = gfx::kGoogleYellow700; 151 color = gfx::kGoogleYellow700;
152 break; 152 break;
153 case AppMenuIconPainter::SEVERITY_HIGH: 153 case AppMenuIconPainter::SEVERITY_HIGH:
154 color = gfx::kGoogleRed700; 154 color = gfx::kGoogleRed700;
155 break; 155 break;
156 } 156 }
157 157
158 gfx::VectorIconId icon_id = gfx::VectorIconId::VECTOR_ICON_NONE; 158 gfx::VectorIconId icon_id = gfx::VectorIconId::VECTOR_ICON_NONE;
159 switch (type_) { 159 switch (type_) {
160 case AppMenuBadgeController::BadgeType::NONE: 160 case AppMenuIconController::IconType::NONE:
161 icon_id = gfx::VectorIconId::BROWSER_TOOLS; 161 icon_id = gfx::VectorIconId::BROWSER_TOOLS;
162 DCHECK_EQ(severity_, AppMenuIconPainter::SEVERITY_NONE); 162 DCHECK_EQ(severity_, AppMenuIconPainter::SEVERITY_NONE);
163 break; 163 break;
164 case AppMenuBadgeController::BadgeType::UPGRADE_NOTIFICATION: 164 case AppMenuIconController::IconType::UPGRADE_NOTIFICATION:
165 icon_id = gfx::VectorIconId::BROWSER_TOOLS_UPDATE; 165 icon_id = gfx::VectorIconId::BROWSER_TOOLS_UPDATE;
166 break; 166 break;
167 case AppMenuBadgeController::BadgeType::GLOBAL_ERROR: 167 case AppMenuIconController::IconType::GLOBAL_ERROR:
168 icon_id = gfx::VectorIconId::BROWSER_TOOLS_ERROR; 168 icon_id = gfx::VectorIconId::BROWSER_TOOLS_ERROR;
169 break; 169 break;
170 case AppMenuBadgeController::BadgeType::INCOMPATIBILITY_WARNING: 170 case AppMenuIconController::IconType::INCOMPATIBILITY_WARNING:
171 icon_id = gfx::VectorIconId::BROWSER_TOOLS_WARNING; 171 icon_id = gfx::VectorIconId::BROWSER_TOOLS_WARNING;
172 break; 172 break;
173 } 173 }
174 174
175 SetImage(views::Button::STATE_NORMAL, gfx::CreateVectorIcon(icon_id, color)); 175 SetImage(views::Button::STATE_NORMAL, gfx::CreateVectorIcon(icon_id, color));
176 } 176 }
177 177
178 void AppMenuButton::SetTrailingMargin(int margin) { 178 void AppMenuButton::SetTrailingMargin(int margin) {
179 margin_trailing_ = margin; 179 margin_trailing_ = margin;
180 180
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 views::MenuButton::OnPaint(canvas); 267 views::MenuButton::OnPaint(canvas);
268 if (ui::MaterialDesignController::IsModeMaterial()) 268 if (ui::MaterialDesignController::IsModeMaterial())
269 return; 269 return;
270 // Use GetPreferredSize() to center the icon inside the visible bounds rather 270 // Use GetPreferredSize() to center the icon inside the visible bounds rather
271 // than the whole size() (which may refer to hit test region extended to the 271 // than the whole size() (which may refer to hit test region extended to the
272 // end of the toolbar in maximized mode). 272 // end of the toolbar in maximized mode).
273 icon_painter_->Paint(canvas, GetThemeProvider(), 273 icon_painter_->Paint(canvas, GetThemeProvider(),
274 gfx::Rect(GetPreferredSize()), 274 gfx::Rect(GetPreferredSize()),
275 AppMenuIconPainter::BEZEL_NONE); 275 AppMenuIconPainter::BEZEL_NONE);
276 } 276 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698