Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4648)

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

Issue 2039363003: FirstMeaningfulPaint UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/page_load_metrics/page_load_timing.cc ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
index ef32d84b88bcfd6a76e543df7748571467afc67e..2b156854c61d0fd39a68e045dacdd93758528cb6 100644
--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
@@ -124,9 +124,10 @@ PageLoadTiming MetricsRenderFrameObserver::GetTiming() const {
timing.navigation_start = base::Time::FromDoubleT(start);
if (perf.responseStart() > 0.0)
timing.response_start = ClampDelta(perf.responseStart(), start);
- if (perf.domContentLoadedEventStart() > 0.0)
+ if (perf.domContentLoadedEventStart() > 0.0) {
timing.dom_content_loaded_event_start =
ClampDelta(perf.domContentLoadedEventStart(), start);
+ }
if (perf.loadEventStart() > 0.0)
timing.load_event_start = ClampDelta(perf.loadEventStart(), start);
if (perf.firstLayout() > 0.0)
@@ -137,9 +138,14 @@ PageLoadTiming MetricsRenderFrameObserver::GetTiming() const {
timing.first_text_paint = ClampDelta(perf.firstTextPaint(), start);
if (perf.firstImagePaint() > 0.0)
timing.first_image_paint = ClampDelta(perf.firstImagePaint(), start);
- if (perf.firstContentfulPaint() > 0.0)
+ if (perf.firstContentfulPaint() > 0.0) {
timing.first_contentful_paint =
ClampDelta(perf.firstContentfulPaint(), start);
+ }
+ if (perf.firstMeaningfulPaint() > 0.0) {
+ timing.first_meaningful_paint =
+ ClampDelta(perf.firstMeaningfulPaint(), start);
+ }
if (perf.parseStart() > 0.0)
timing.parse_start = ClampDelta(perf.parseStart(), start);
if (perf.parseStop() > 0.0)
« no previous file with comments | « chrome/common/page_load_metrics/page_load_timing.cc ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698