Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: chrome/common/page_load_metrics/page_load_timing.cc

Issue 2039363003: FirstMeaningfulPaint UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/page_load_metrics/page_load_timing.cc
diff --git a/chrome/common/page_load_metrics/page_load_timing.cc b/chrome/common/page_load_metrics/page_load_timing.cc
index 21c3204489a6074d4735cb44d5676af36e648587..d96844881c72490c9aa961af1ed3f5712b36fe83 100644
--- a/chrome/common/page_load_metrics/page_load_timing.cc
+++ b/chrome/common/page_load_metrics/page_load_timing.cc
@@ -23,6 +23,7 @@ bool PageLoadTiming::operator==(const PageLoadTiming& other) const {
first_text_paint == other.first_text_paint &&
first_image_paint == other.first_image_paint &&
first_contentful_paint == other.first_contentful_paint &&
+ first_meaningful_paint == other.first_meaningful_paint &&
parse_start == other.parse_start && parse_stop == other.parse_stop &&
parse_blocked_on_script_load_duration ==
other.parse_blocked_on_script_load_duration &&
@@ -34,8 +35,9 @@ bool PageLoadTiming::IsEmpty() const {
return navigation_start.is_null() && !response_start &&
!dom_content_loaded_event_start && !load_event_start &&
!first_layout && !first_paint && !first_text_paint &&
- !first_image_paint && !first_contentful_paint && !parse_start &&
- !parse_stop && !parse_blocked_on_script_load_duration &&
+ !first_image_paint && !first_contentful_paint &&
+ !first_meaningful_paint && !parse_start && !parse_stop &&
+ !parse_blocked_on_script_load_duration &&
!parse_blocked_on_script_load_from_document_write_duration;
}
« no previous file with comments | « chrome/common/page_load_metrics/page_load_timing.h ('k') | chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698