Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

Issue 2039363003: FirstMeaningfulPaint UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
index ef32d84b88bcfd6a76e543df7748571467afc67e..54fb495457c9c18e02d0b0f3f209df276d04f4a4 100644
--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
@@ -140,6 +140,9 @@ PageLoadTiming MetricsRenderFrameObserver::GetTiming() const {
if (perf.firstContentfulPaint() > 0.0)
timing.first_contentful_paint =
ClampDelta(perf.firstContentfulPaint(), start);
+ if (perf.firstMeaningfulPaint() > 0.0)
Charlie Harrison 2016/08/04 02:18:29 nit: Can you wrap the if with braces? I'm not a fa
Kunihiko Sakamoto 2016/08/04 02:56:14 Done.
+ timing.first_meaningful_paint =
+ ClampDelta(perf.firstMeaningfulPaint(), start);
if (perf.parseStart() > 0.0)
timing.parse_start = ClampDelta(perf.parseStart(), start);
if (perf.parseStop() > 0.0)

Powered by Google App Engine
This is Rietveld 408576698