FirstMeaningfulPaint UMA

chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
 
 #include <string>
 
 #include "base/memory/ptr_util.h"
 #include "base/time/time.h"
@@ skipping 122 matching lines @@
     timing.first_layout = ClampDelta(perf.firstLayout(), start);
   if (perf.firstPaint() > 0.0)
     timing.first_paint = ClampDelta(perf.firstPaint(), start);
   if (perf.firstTextPaint() > 0.0)
     timing.first_text_paint = ClampDelta(perf.firstTextPaint(), start);
   if (perf.firstImagePaint() > 0.0)
     timing.first_image_paint = ClampDelta(perf.firstImagePaint(), start);
   if (perf.firstContentfulPaint() > 0.0)
     timing.first_contentful_paint =
         ClampDelta(perf.firstContentfulPaint(), start);
+  if (perf.firstMeaningfulPaint() > 0.0)

[Charlie Harrison, 2016/08/04 02:18:29]

nit: Can you wrap the if with braces? I'm not a fan of multi-line if bodies
without braces. (Can do it for FCP too).

[Kunihiko Sakamoto, 2016/08/04 02:56:14]

Done.

+    timing.first_meaningful_paint =
+        ClampDelta(perf.firstMeaningfulPaint(), start);
   if (perf.parseStart() > 0.0)
     timing.parse_start = ClampDelta(perf.parseStart(), start);
   if (perf.parseStop() > 0.0)
     timing.parse_stop = ClampDelta(perf.parseStop(), start);
   if (timing.parse_start) {
     // If we started parsing, record all parser durations such as the amount of
     // time blocked on script load, even if those values are zero.
     timing.parse_blocked_on_script_load_duration =
         base::TimeDelta::FromSecondsD(perf.parseBlockedOnScriptLoadDuration());
     timing.parse_blocked_on_script_load_from_document_write_duration =
@@ skipping 11 matching lines @@
   bool no_frame = !render_frame() || !render_frame()->GetWebFrame();
   DCHECK(!no_frame);
   return no_frame;
 }
 
 void MetricsRenderFrameObserver::OnDestruct() {
   delete this;
 }
 
 }  // namespace page_load_metrics