chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc - Issue 2039363003: FirstMeaningfulPaint UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

Issue 2039363003: FirstMeaningfulPaint UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready for review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

index fa2a12f4f73849092b010f72b72f08bd376eff06..ffc22d31d336311900e076ad692dc90fead232ab 100644

--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

@@ -138,6 +138,9 @@ PageLoadTiming MetricsRenderFrameObserver::GetTiming() const {

if (perf.firstContentfulPaint() > 0.0)

timing.first_contentful_paint =

ClampDelta(perf.firstContentfulPaint(), start);

+ if (perf.firstMeaningfulPaint() > 0.0)

+ timing.first_meaningful_paint =

+ ClampDelta(perf.firstMeaningfulPaint(), start);

if (perf.parseStart() > 0.0)

timing.parse_start = ClampDelta(perf.parseStart(), start);

if (perf.parseStop() > 0.0)