Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: build/android/pylib/perf/setup.py

Issue 2039363002: [Android] Ensure perf test runner does not create shards for blacklisted devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: better solution Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/perf/setup.py
diff --git a/build/android/pylib/perf/setup.py b/build/android/pylib/perf/setup.py
index 31db14fa031e0cccfe8b573bb6bc0b56f9dbaaeb..8e2c0e68df7f73d292e4d29e50fa25be782d1177 100644
--- a/build/android/pylib/perf/setup.py
+++ b/build/android/pylib/perf/setup.py
@@ -98,8 +98,12 @@ def Setup(test_options, active_devices):
flaky_steps = json.load(f)
def TestRunnerFactory(device, shard_index):
- return test_runner.TestRunner(
- test_options, device, shard_index, len(all_devices),
- steps_dict, flaky_steps)
+ if str(device) in active_devices:
+ return test_runner.TestRunner(
+ test_options, device, shard_index, len(all_devices),
+ steps_dict, flaky_steps)
+ logging.info('Device %s is not active. Will not create shard %s.',
+ str(device), shard_index)
+ return None
return (TestRunnerFactory, sorted_step_names, all_devices)
« build/android/pylib/base/test_dispatcher.py ('K') | « build/android/pylib/base/test_dispatcher.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698