build/android/pylib/base/test_dispatcher.py - Issue 2039363002: [Android] Ensure perf test runner does not create shards for blacklisted devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/base/test_dispatcher.py

Issue 2039363002: [Android] Ensure perf test runner does not create shards for blacklisted devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: better solution Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/base/test_dispatcher.py

diff --git a/build/android/pylib/base/test_dispatcher.py b/build/android/pylib/base/test_dispatcher.py

index c513d9abebf9fe9336a18eb3b771b6fa422cc8c4..774a16c969b6a730bdeab3e7ef449ea4436a3db4 100644

--- a/build/android/pylib/base/test_dispatcher.py

+++ b/build/android/pylib/base/test_dispatcher.py

@@ -147,8 +147,9 @@ def _SetUp(runner_factory, device, out_runners, threadsafe_counter):

index = threadsafe_counter.GetAndIncrement()

logging.warning('Creating shard %s for device %s.', index, device)

runner = runner_factory(device, index)

- runner.SetUp()

- out_runners.append(runner)

+ if runner:

jbudorick 2016/06/07 00:27:26 Nit: remove the logging from the runner_factory an

rnephew (Reviews Here) 2016/06/07 00:40:31 Done.

+ runner.SetUp()

+ out_runners.append(runner)

except (device_errors.CommandFailedError,

device_errors.CommandTimeoutError,

device_errors.DeviceUnreachableError):

« no previous file with comments | « no previous file | build/android/pylib/perf/setup.py » ('j') | no next file with comments »