Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2039253002: Removing ash::Shelf::shelf_model() (Closed)

Created:
4 years, 6 months ago by mfomitchev
Modified:
4 years, 6 months ago
Reviewers:
James Cook, sky
CC:
chromium-reviews, kalyank, sadrul, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@launcher_controller_shelf_model_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing ash::Shelf::shelf_model() Follow up for crrev.com/2039543002. BUG=NONE Committed: https://crrev.com/0c4d8d60a425c7ce8a76805dc89cc2bf52141d3d Cr-Commit-Position: refs/heads/master@{#398386}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Another rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M ash/shelf/shelf.h View 1 2 3 chunks +1 line, -3 lines 0 comments Download
M ash/shelf/shelf.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/extension_launcher_context_menu.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc View 1 2 4 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
mfomitchev
4 years, 6 months ago (2016-06-06 15:47:21 UTC) #3
James Cook
LGTM. Thank you - this makes my life a little easier.
4 years, 6 months ago (2016-06-06 17:07:06 UTC) #5
sky
LGTM
4 years, 6 months ago (2016-06-06 21:34:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039253002/20001
4 years, 6 months ago (2016-06-06 22:18:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/195886)
4 years, 6 months ago (2016-06-06 22:27:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039253002/40001
4 years, 6 months ago (2016-06-07 18:42:58 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-07 21:40:53 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 21:43:45 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0c4d8d60a425c7ce8a76805dc89cc2bf52141d3d
Cr-Commit-Position: refs/heads/master@{#398386}

Powered by Google App Engine
This is Rietveld 408576698