[css-grid] Fix percentage height on grid item's children

third_party/WebKit/Source/core/layout/LayoutBox.cpp

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 1cbedcad8db3996a92f175d35cad6c5aeda90a76..f8e9a8038a8249dea3f6e8b4642b0200f7588c4d 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -2733,6 +2733,8 @@ LayoutUnit LayoutBox::computePercentageLogicalHeight(const Length& height) const
         availableHeight = stretchedFlexHeight;
     } else if (hasOverrideContainingBlockLogicalHeight()) {
         availableHeight = overrideContainingBlockContentLogicalHeight();
+    } else if (cbstyle.logicalHeight().isAuto() && cb->hasOverrideContainingBlockLogicalHeight()) {

[cbiesinger1, 2016/06/06 16:56:57]

This does not seem correct in general. You are now always using the cb's cb
size, not the box's cb size. This works for grid items but not in general,
right? Maybe add a check if cb is a grid item?

[Manuel Rego, 2016/06/06 19:24:09]

overrideContainingBlockLogicalHeight is only used for grid items.
I can add the check cb->isGridItem() but it's not really needed.
If someone else uses overrideContainingBlockLogicalHeight in the future,
probably they'll want the same behavior than for Grid or things won't work.

If we want to add the isGridItem() check here,
I'd do the same on the previous if.

+        availableHeight = cb->overrideContainingBlockContentLogicalHeight();
     } else if (cbstyle.logicalHeight().isFixed()) {
         LayoutUnit contentBoxHeight = cb->adjustContentBoxLogicalHeightForBoxSizing(cbstyle.logicalHeight().value());
         availableHeight = cb->constrainContentBoxLogicalHeightByMinMax(