[css-grid] Fix percentage height on grid item's children

third_party/WebKit/Source/core/layout/LayoutBox.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 2715 matching lines @@
     LayoutUnit stretchedFlexHeight(-1);
     if (cb->isFlexItem())
         stretchedFlexHeight = toLayoutFlexibleBox(cb->parent())->childLogicalHeightForPercentageResolution(*cb);
 
     if (isHorizontalWritingMode() != cb->isHorizontalWritingMode()) {
         availableHeight = containingBlockChild->containingBlockLogicalWidthForContent();
     } else if (stretchedFlexHeight != LayoutUnit(-1)) {
         availableHeight = stretchedFlexHeight;
     } else if (hasOverrideContainingBlockLogicalHeight()) {
         availableHeight = overrideContainingBlockContentLogicalHeight();
+    } else if (cbstyle.logicalHeight().isAuto() && cb->hasOverrideContainingBlockLogicalHeight()) {

[cbiesinger1, 2016/06/06 16:56:57]

This does not seem correct in general. You are now always using the cb's cb
size, not the box's cb size. This works for grid items but not in general,
right? Maybe add a check if cb is a grid item?

[Manuel Rego, 2016/06/06 19:24:09]

overrideContainingBlockLogicalHeight is only used for grid items.
I can add the check cb->isGridItem() but it's not really needed.
If someone else uses overrideContainingBlockLogicalHeight in the future,
probably they'll want the same behavior than for Grid or things won't work.

If we want to add the isGridItem() check here,
I'd do the same on the previous if.

+        availableHeight = cb->overrideContainingBlockContentLogicalHeight();
     } else if (cbstyle.logicalHeight().isFixed()) {
         LayoutUnit contentBoxHeight = cb->adjustContentBoxLogicalHeightForBoxSizing(cbstyle.logicalHeight().value());
         availableHeight = cb->constrainContentBoxLogicalHeightByMinMax(
             contentBoxHeight - cb->scrollbarLogicalHeight(), LayoutUnit(-1)).clampNegativeToZero();
         if (cb->isTableCell()) {
             includeBorderPadding = true;
             // We're sizing content to the height from the cell's style so don't involve the intrinsic padding used to align the content.
             availableHeight -= cb->computedCSSPaddingBefore() + cb->computedCSSPaddingAfter() + cb->borderBefore() + cb->borderAfter();
         }
     } else if (cb->isTableCell()) {
@@ skipping 2175 matching lines @@
         m_rareData->m_snapAreas->remove(&snapArea);
     }
 }
 
 SnapAreaSet* LayoutBox::snapAreas() const
 {
     return m_rareData ? m_rareData->m_snapAreas.get() : nullptr;
 }
 
 } // namespace blink