third_party/WebKit/Source/core/css/cssom/CSSRotation.h - Issue 2039093003: [Typed OM] Implement CSSValue->CSSRotation conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSRotation.h

Issue 2039093003: [Typed OM] Implement CSSValue->CSSRotation conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-rotation.html ('k') | third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/CSSRotation.h

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSRotation.h b/third_party/WebKit/Source/core/css/cssom/CSSRotation.h

index 87d2cdaa81e3b34d83bd1385b8e69627b97ba6bb..ee6d7065b6414b9cdf20f204208ee822ef2d69c3 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSRotation.h

+++ b/third_party/WebKit/Source/core/css/cssom/CSSRotation.h

@@ -35,7 +35,7 @@ public:

return new CSSRotation(x, y, z, angleValue->degrees());

}

- static CSSRotation* fromCSSValue(const CSSFunctionValue&) { return nullptr; }

+ static CSSRotation* fromCSSValue(const CSSFunctionValue&);

double angle() const { return m_angle; }

double x() const { return m_x; }