[Offline Pages] Link the internals page with the offline model and request

content/browser/webui/web_ui_message_handler.cc

Index: content/browser/webui/web_ui_message_handler.cc
diff --git a/content/browser/webui/web_ui_message_handler.cc b/content/browser/webui/web_ui_message_handler.cc
index 41ca291e03e8ec768fab1e9de23d2dc3f05eca97..1df0708f6a9f6a4a2ae01f2a1f0827ee4a83839e 100644
--- a/content/browser/webui/web_ui_message_handler.cc
+++ b/content/browser/webui/web_ui_message_handler.cc
@@ -81,6 +81,12 @@ void WebUIMessageHandler::ResolveJavascriptCallback(
                          base::FundamentalValue(true), response);
 }
 
+void WebUIMessageHandler::ResolveJavascriptCallback(

[dpapad, 2016/06/10 21:08:55]

I would prefer to not overload ResolveJavascriptCallback(). If you think this
version is more useful, then we can maybe allow only this version, but still
this belongs better in a separate CL (you need extra OWNERS approval just
because of touching this file).

For now just call base::StringValue() from your handler directly, like
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/font_ha....

[Dan Beam, 2016/06/13 19:13:30]

the C++ style guide discourages overloading:
https://google.github.io/styleguide/cppguide.html#Function_Overloading

+    const std::string& callback_id,
+    const base::Value& response) {
+  ResolveJavascriptCallback(base::StringValue(callback_id), response);
+}
+
 void WebUIMessageHandler::RejectJavascriptCallback(
     const base::Value& callback_id,
     const base::Value& response) {