[Offline Pages] Link the internals page with the offline model and request

content/browser/webui/web_ui_message_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/web_ui_message_handler.h"
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
@@ skipping 63 matching lines @@
 }
 
 void WebUIMessageHandler::ResolveJavascriptCallback(
     const base::Value& callback_id,
     const base::Value& response) {
   // cr.webUIResponse is a global JS function exposed from cr.js.
   CallJavascriptFunction("cr.webUIResponse", callback_id,
                          base::FundamentalValue(true), response);
 }
 
+void WebUIMessageHandler::ResolveJavascriptCallback(

[dpapad, 2016/06/10 21:08:55]

I would prefer to not overload ResolveJavascriptCallback(). If you think this
version is more useful, then we can maybe allow only this version, but still
this belongs better in a separate CL (you need extra OWNERS approval just
because of touching this file).

For now just call base::StringValue() from your handler directly, like
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/font_ha....

[Dan Beam, 2016/06/13 19:13:30]

the C++ style guide discourages overloading:
https://google.github.io/styleguide/cppguide.html#Function_Overloading

+    const std::string& callback_id,
+    const base::Value& response) {
+  ResolveJavascriptCallback(base::StringValue(callback_id), response);
+}
+
 void WebUIMessageHandler::RejectJavascriptCallback(
     const base::Value& callback_id,
     const base::Value& response) {
   // cr.webUIResponse is a global JS function exposed from cr.js.
   CallJavascriptFunction("cr.webUIResponse", callback_id,
                          base::FundamentalValue(false), response);
 }
 
 }  // namespace content