third_party/WebKit/Source/platform/graphics/paint/PaintController.h - Issue 2038873002: Check new display item list committed when destructing PaintController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.h

Issue 2038873002: Check new display item list committed when destructing PaintController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.h

diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h

index ce39ebdb56b51d15ed71d209dd1a0ddc868d7710..cdcd29a18fd2a93796a45e8a3238721807ca2a61 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h

+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h

@@ -44,6 +44,8 @@ public:

~PaintController()

{

+ // New display items should be committed before PaintController is destructed.

+ DCHECK(m_newDisplayItemList.isEmpty());

#if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS

DisplayItemClient::endShouldKeepAliveAllClients(this);

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »