Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.h

Issue 2038873002: Check new display item list committed when destructing PaintController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PaintController_h 5 #ifndef PaintController_h
6 #define PaintController_h 6 #define PaintController_h
7 7
8 #include "platform/PlatformExport.h" 8 #include "platform/PlatformExport.h"
9 #include "platform/RuntimeEnabledFeatures.h" 9 #include "platform/RuntimeEnabledFeatures.h"
10 #include "platform/geometry/IntRect.h" 10 #include "platform/geometry/IntRect.h"
(...skipping 26 matching lines...) Expand all
37 WTF_MAKE_NONCOPYABLE(PaintController); 37 WTF_MAKE_NONCOPYABLE(PaintController);
38 USING_FAST_MALLOC(PaintController); 38 USING_FAST_MALLOC(PaintController);
39 public: 39 public:
40 static PassOwnPtr<PaintController> create() 40 static PassOwnPtr<PaintController> create()
41 { 41 {
42 return adoptPtr(new PaintController()); 42 return adoptPtr(new PaintController());
43 } 43 }
44 44
45 ~PaintController() 45 ~PaintController()
46 { 46 {
47 // New display items should be committed before PaintController is destr ucted.
48 DCHECK(m_newDisplayItemList.isEmpty());
47 #if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS 49 #if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS
48 DisplayItemClient::endShouldKeepAliveAllClients(this); 50 DisplayItemClient::endShouldKeepAliveAllClients(this);
49 #endif 51 #endif
50 } 52 }
51 53
52 void invalidateAll(); 54 void invalidateAll();
53 55
54 // Record when paint offsets change during paint. 56 // Record when paint offsets change during paint.
55 void invalidatePaintOffset(const DisplayItemClient&); 57 void invalidatePaintOffset(const DisplayItemClient&);
56 #if DCHECK_IS_ON() 58 #if DCHECK_IS_ON()
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 // easily find where the duplicated ids are from. 234 // easily find where the duplicated ids are from.
233 DisplayItemIndicesByClientMap m_newDisplayItemIndicesByClient; 235 DisplayItemIndicesByClientMap m_newDisplayItemIndicesByClient;
234 #endif 236 #endif
235 237
236 DisplayItemCacheGeneration m_currentCacheGeneration; 238 DisplayItemCacheGeneration m_currentCacheGeneration;
237 }; 239 };
238 240
239 } // namespace blink 241 } // namespace blink
240 242
241 #endif // PaintController_h 243 #endif // PaintController_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698