chrome/browser/search/instant_service_observer.cc - Issue 20388003: Reload Instant NTP and Instant-process tabs on search url change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/instant_service_observer.cc

Issue 20388003: Reload Instant NTP and Instant-process tabs on search url change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments, added a test to address the bug Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/search/instant_service.cc ('K') | « chrome/browser/search/instant_service_observer.h ('k') | chrome/browser/search/instant_service_unittest.cc » ('j') | chrome/browser/search/instant_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search/instant_service_observer.cc

diff --git a/chrome/browser/search/instant_service_observer.cc b/chrome/browser/search/instant_service_observer.cc

new file mode 100644

index 0000000000000000000000000000000000000000..7b0561532a09f44635fdc5c480dbc2f1cb335ba8

--- /dev/null

+++ b/chrome/browser/search/instant_service_observer.cc

@@ -0,0 +1,14 @@

Jered 2013/08/16 00:13:23 Why do we need this default implementation? It doe

Anuj 2013/08/22 00:40:45 Allows implementors to pick which ones they really

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

+#include "chrome/browser/search/instant_service_observer.h"

+void InstantServiceObserver::ThemeInfoChanged(const ThemeBackgroundInfo&) {}

Jered 2013/08/16 00:13:23 Here and below, put the closing brace on the next

Anuj 2013/08/22 00:40:45 I blame "git cl format". done.

+void InstantServiceObserver::MostVisitedItemsChanged(

+ const std::vector<InstantMostVisitedItem>&) {}

+void InstantServiceObserver::DefaultSearchProviderChanged() {}

+void InstantServiceObserver::GoogleURLUpdated() {}