chrome/browser/search/instant_service_observer.cc - Issue 20388003: Reload Instant NTP and Instant-process tabs on search url change

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/search/instant_service_observer.cc

Issue 20388003: Reload Instant NTP and Instant-process tabs on search url change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments, added a test to address the bug Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/search/instant_service.cc ('K') | « chrome/browser/search/instant_service_observer.h ('k') | chrome/browser/search/instant_service_unittest.cc » ('j') | chrome/browser/search/instant_service_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.
	Jered 2013/08/16 00:13:23 Why do we need this default implementation? It doe Why do we need this default implementation? It doesn't seem to do anything. Anuj 2013/08/22 00:40:45 Allows implementors to pick which ones they really Show quoted text On 2013/08/16 00:13:23, Jered wrote: > Why do we need this default implementation? It doesn't seem to do anything. Allows implementors to pick which ones they really want to implement.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/search/instant_service_observer.h"

	6

	7 void InstantServiceObserver::ThemeInfoChanged(const ThemeBackgroundInfo&) {}
	Jered 2013/08/16 00:13:23 Here and below, put the closing brace on the next Here and below, put the closing brace on the next line. Anuj 2013/08/22 00:40:45 I blame "git cl format". done. Show quoted text On 2013/08/16 00:13:23, Jered wrote: > Here and below, put the closing brace on the next line. I blame "git cl format". done.
	8

	9 void InstantServiceObserver::MostVisitedItemsChanged(

	10 const std::vector<InstantMostVisitedItem>&) {}

	11

	12 void InstantServiceObserver::DefaultSearchProviderChanged() {}

	13

	14 void InstantServiceObserver::GoogleURLUpdated() {}

OLD	NEW