Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Issue 2038703002: Revert of Remove '--ignore-certificate-errors' from RendererMemoryBlinkMemoryMobile (Closed)

Created:
4 years, 6 months ago by Zhen Wang
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove '--ignore-certificate-errors' from RendererMemoryBlinkMemoryMobile (patchset #1 id:20001 of https://codereview.chromium.org/2024733003/ ) Reason for revert: This CL causes memory.blink_memory_mobile to fail on Android perf bots. See http://crbug.com/616861 Original issue's description: > Remove '--ignore-certificate-errors' from RendererMemoryBlinkMemoryMobile > > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq > > Committed: https://crrev.com/c39b0cc8a516de1fa57d032dc0135a4eadfe2c9e > Cr-Commit-Position: refs/heads/master@{#397358} TBR=nednguyen@google.com,nednguyen@chromium.org,bashi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/f1694ca3906f2058993518900fdf02f1dfe30dd1 Cr-Commit-Position: refs/heads/master@{#397536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M tools/perf/benchmarks/memory_infra.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Zhen Wang
Created Revert of Remove '--ignore-certificate-errors' from RendererMemoryBlinkMemoryMobile
4 years, 6 months ago (2016-06-02 23:02:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2038703002/1
4 years, 6 months ago (2016-06-02 23:04:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 23:05:45 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f1694ca3906f2058993518900fdf02f1dfe30dd1 Cr-Commit-Position: refs/heads/master@{#397536}
4 years, 6 months ago (2016-06-02 23:07:26 UTC) #6
bashi
4 years, 6 months ago (2016-06-02 23:45:31 UTC) #7
Message was sent while issue was closed.
On 2016/06/02 23:07:26, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/f1694ca3906f2058993518900fdf02f1dfe30dd1
> Cr-Commit-Position: refs/heads/master@{#397536}

lgtm. Thanks for the triage.

Powered by Google App Engine
This is Rietveld 408576698