Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2024733003: Remove '--ignore-certificate-errors' from RendererMemoryBlinkMemoryMobile (Closed)

Created:
4 years, 6 months ago by bashi
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove '--ignore-certificate-errors' from RendererMemoryBlinkMemoryMobile CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/c39b0cc8a516de1fa57d032dc0135a4eadfe2c9e Cr-Commit-Position: refs/heads/master@{#397358}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M tools/perf/benchmarks/memory_infra.py View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
bashi
PTAL?
4 years, 6 months ago (2016-05-31 09:36:06 UTC) #5
nednguyen
lgtm
4 years, 6 months ago (2016-05-31 17:07:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024733003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024733003/20001
4 years, 6 months ago (2016-06-01 23:01:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239373)
4 years, 6 months ago (2016-06-02 01:59:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024733003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024733003/20001
4 years, 6 months ago (2016-06-02 02:09:29 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239446)
4 years, 6 months ago (2016-06-02 02:57:00 UTC) #14
nednguyen
On 2016/06/02 02:57:00, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-06-02 03:06:36 UTC) #15
bashi
On 2016/06/02 03:06:36, nednguyen wrote: > On 2016/06/02 02:57:00, commit-bot: I haz the power wrote: ...
4 years, 6 months ago (2016-06-02 03:12:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024733003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024733003/20001
4 years, 6 months ago (2016-06-02 10:11:03 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-02 10:53:15 UTC) #20
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c39b0cc8a516de1fa57d032dc0135a4eadfe2c9e Cr-Commit-Position: refs/heads/master@{#397358}
4 years, 6 months ago (2016-06-02 10:54:19 UTC) #22
Zhen Wang
4 years, 6 months ago (2016-06-02 23:02:02 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/2038703002/ by zhenw@chromium.org.

The reason for reverting is: This CL causes memory.blink_memory_mobile to fail
on Android perf bots. See http://crbug.com/616861.

Powered by Google App Engine
This is Rietveld 408576698