Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 20386: Fix the Facebook sidebar.... (Closed)

11 years, 10 months ago by Mark Larson
9 years, 7 months ago


Fix the Facebook sidebar. This is actually just a replica of the following patch (internal Google URL): http://go/facebook-skia-patch Apparently the changes made by were not upstreamed to Skia. In the most recent skia update (r7308), these changes were dropped. I've tested the changes locally, and it fixes Facebook. However, it could possibly break layout tests. BUG=5564 R= brettw TEST= I'd kill for one. Committed:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -14 lines) Patch
M skia/sgl/SkBitmapProcState.h View 2 chunks +4 lines, -1 line 0 comments Download
M skia/sgl/SkBitmapProcState.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M skia/sgl/SkBitmapProcState_matrix.h View 5 chunks +42 lines, -0 lines 0 comments Download
M skia/sgl/SkBitmapProcState_matrixProcs.cpp View 6 chunks +61 lines, -11 lines 0 comments Download


Total messages: 1 (0 generated)
Mark Larson
11 years, 10 months ago (2009-02-15 04:23:26 UTC) #1


Powered by Google App Engine
This is Rietveld 408576698