Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(41)

Issue 20386: Fix the Facebook sidebar.... (Closed)

Created:
10 years, 6 months ago by Mark Larson
Modified:
8 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix the Facebook sidebar. This is actually just a replica of the following patch (internal Google URL): http://go/facebook-skia-patch Apparently the changes made by yzshen@google.com were not upstreamed to Skia. In the most recent skia update (r7308), these changes were dropped. I've tested the changes locally, and it fixes Facebook. However, it could possibly break layout tests. BUG=5564 R= brettw TEST= I'd kill for one. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -14 lines) Patch
M skia/sgl/SkBitmapProcState.h View 2 chunks +4 lines, -1 line 0 comments Download
M skia/sgl/SkBitmapProcState.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M skia/sgl/SkBitmapProcState_matrix.h View 5 chunks +42 lines, -0 lines 0 comments Download
M skia/sgl/SkBitmapProcState_matrixProcs.cpp View 6 chunks +61 lines, -11 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mark Larson
10 years, 6 months ago (2009-02-15 04:23:26 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698