Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2038453002: Typed CSSOM: Rename Matrix to CSSMatrix and MatrixTransformComponent to CSSMatrixTransformComponent (Closed)

Created:
4 years, 6 months ago by rjwright
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Typed CSSOM: Rename Matrix to CSSMatrix and MatrixTransformComponent to CSSMatrixTransformComponent. I didn't rename MatrixTranformComponent to CSSMatrix because WebKitCSSMatrix is implemented as CSSMatrix. Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#cssmatrix Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159 BUG=610173 Committed: https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd Cr-Commit-Position: refs/heads/master@{#398165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -441 lines) Patch
A + third_party/WebKit/LayoutTests/typedcssom/cssMatrix.html View 3 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssRotation.html View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssScale.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssSkew.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/matrixTransformComponent.html View 1 chunk +0 lines, -80 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/transformValue.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 4 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSMatrix.idl View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSMatrixTransformComponent.h View 3 chunks +20 lines, -20 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSMatrixTransformComponent.cpp View 4 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSPerspective.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSRotation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSScale.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSSkew.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTranslation.h View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/css/cssom/Matrix.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.h View 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp View 1 chunk +0 lines, -101 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/TransformComponent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/TransformComponent.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
rjwright
4 years, 6 months ago (2016-06-02 05:52:31 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2038453002/1
4 years, 6 months ago (2016-06-02 05:52:39 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-02 10:19:14 UTC) #7
Timothy Loh
lgtm, but change the description to say you didn't rename the class to CSSMatrix because ...
4 years, 6 months ago (2016-06-03 01:29:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038453002/1
4 years, 6 months ago (2016-06-06 19:10:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 00:14:59 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 00:16:11 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd
Cr-Commit-Position: refs/heads/master@{#398165}

Powered by Google App Engine
This is Rietveld 408576698