Add a new way to record Rappor metrics for MIDI permissions.

Add a new way to record Rappor metrics for MIDI permissions.

Rappor metrics for constant permissions were added, but it was based
on old way that may be deprecated soon. This change adds new way to
record metrics that others use.

Also, rappor.xml is updated that was missed in the last change.

BUG=465661
TBR=mlamouri@chromium.org

Committed: https://crrev.com/b2c4d4e8b507616425a23d6bb5b9df5ff6f34064
Cr-Commit-Position: refs/heads/master@{#398770}

[Takashi Toyoshima, 2016-06-06 06:53:11]

Description was changed from

==========
Add a new way to record Rappor metrics for MIDI permissions.

Rappor metrics for constant permissions were added, but it was based
on old way that may be deprecated soon. This change adds new way to
record metrics that others use.

Also, rappor.xml is updated that was missed in the last change.

BUG=465661
==========

to

==========
Add a new way to record Rappor metrics for MIDI permissions.

Rappor metrics for constant permissions were added, but it was based
on old way that may be deprecated soon. This change adds new way to
record metrics that others use.

Also, rappor.xml is updated that was missed in the last change.

BUG=465661
==========

[Takashi Toyoshima, 2016-06-06 06:53:39]

toyoshim@chromium.org changed reviewers:
+ isherman@chromium.org, mlamouri@chromium.org

[Takashi Toyoshima, 2016-06-06 06:58:46]

Mounir:
I added rappor metrics for MIDI, but I noticed that the way I used is in in the
middle of transition.
I want to add the new way so that it can be aligned with others, and dominickn@
can handle it together when it's ready.

I added dominickn@ to CC so that he notices that I'm adding this new record.


Ilya:
Can you review rappor.xml?

[mlamouri (slow - plz ping), 2016-06-06 13:05:15]

mlamouri@chromium.org changed reviewers:
+ dominickn@chromium.org

[mlamouri (slow - plz ping), 2016-06-06 13:05:16]

I will happily rubberstamp this if dominickn@ is happy with the change. Adding
him as reviewer.

[Ilya Sherman, 2016-06-06 18:19:50]

LGTM, plus CC'ing Steve in case he'd like to sanity-check the RAPPOR details.

https://codereview.chromium.org/2038403002/diff/1/tools/metrics/rappor/rappor...
File tools/metrics/rappor/rappor.xml (right):

https://codereview.chromium.org/2038403002/diff/1/tools/metrics/rappor/rappor...
tools/metrics/rappor/rappor.xml:750: as of M52. The domain that requests using
MIDI devices.
Should this say M53?  M52 is already branched, IIRC.

[Steven Holte, 2016-06-06 22:18:11]

On 2016/06/06 18:19:50, Ilya Sherman wrote:
> LGTM, plus CC'ing Steve in case he'd like to sanity-check the RAPPOR details.
> 
>
https://codereview.chromium.org/2038403002/diff/1/tools/metrics/rappor/rappor...
> File tools/metrics/rappor/rappor.xml (right):
> 
>
https://codereview.chromium.org/2038403002/diff/1/tools/metrics/rappor/rappor...
> tools/metrics/rappor/rappor.xml:750: as of M52. The domain that requests using
> MIDI devices.
> Should this say M53?  M52 is already branched, IIRC.

lgtm, assuming this falls within the scope dominickn@ discussed with Chrome
Privacy

[dominickn, 2016-06-07 00:02:16]

lgtm % isherman's nit regarding M53. I'll be removing the deprecated metrics
starting from after M52 goes stable (so we can compare performance); this one
will wait until M53 goes stable before I remove it for similar reasons.

[Takashi Toyoshima, 2016-06-07 03:37:48]

https://codereview.chromium.org/2038403002/diff/1/tools/metrics/rappor/rappor...
File tools/metrics/rappor/rappor.xml (right):

https://codereview.chromium.org/2038403002/diff/1/tools/metrics/rappor/rappor...
tools/metrics/rappor/rappor.xml:750: as of M52. The domain that requests using
MIDI devices.
On 2016/06/06 18:19:50, Ilya Sherman wrote:
> Should this say M53?  M52 is already branched, IIRC.

Done.

[Takashi Toyoshima, 2016-06-09 02:39:00]

Description was changed from

==========
Add a new way to record Rappor metrics for MIDI permissions.

Rappor metrics for constant permissions were added, but it was based
on old way that may be deprecated soon. This change adds new way to
record metrics that others use.

Also, rappor.xml is updated that was missed in the last change.

BUG=465661
==========

to

==========
Add a new way to record Rappor metrics for MIDI permissions.

Rappor metrics for constant permissions were added, but it was based
on old way that may be deprecated soon. This change adds new way to
record metrics that others use.

Also, rappor.xml is updated that was missed in the last change.

BUG=465661
TBR=mlamouri@chromium.org
==========

[Takashi Toyoshima, 2016-06-09 02:39:52]

I'll submit this with TBR as per #5

[Takashi Toyoshima, 2016-06-09 02:40:00]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-06-09 02:40:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, isherman@chromium.org, holte@chromium.org
Link to the patchset: https://codereview.chromium.org/2038403002/#ps20001
(title: "M52 -> M53")

[commit-bot: I haz the power, 2016-06-09 02:40:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2038403002/20001

[commit-bot: I haz the power, 2016-06-09 03:23:37]

Description was changed from

==========
Add a new way to record Rappor metrics for MIDI permissions.

Rappor metrics for constant permissions were added, but it was based
on old way that may be deprecated soon. This change adds new way to
record metrics that others use.

Also, rappor.xml is updated that was missed in the last change.

BUG=465661
TBR=mlamouri@chromium.org
==========

to

==========
Add a new way to record Rappor metrics for MIDI permissions.

Rappor metrics for constant permissions were added, but it was based
on old way that may be deprecated soon. This change adds new way to
record metrics that others use.

Also, rappor.xml is updated that was missed in the last change.

BUG=465661
TBR=mlamouri@chromium.org
==========

[commit-bot: I haz the power, 2016-06-09 03:23:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-09 03:25:21]

Description was changed from

==========
Add a new way to record Rappor metrics for MIDI permissions.

Rappor metrics for constant permissions were added, but it was based
on old way that may be deprecated soon. This change adds new way to
record metrics that others use.

Also, rappor.xml is updated that was missed in the last change.

BUG=465661
TBR=mlamouri@chromium.org
==========

to

==========
Add a new way to record Rappor metrics for MIDI permissions.

Rappor metrics for constant permissions were added, but it was based
on old way that may be deprecated soon. This change adds new way to
record metrics that others use.

Also, rappor.xml is updated that was missed in the last change.

BUG=465661
TBR=mlamouri@chromium.org

Committed: https://crrev.com/b2c4d4e8b507616425a23d6bb5b9df5ff6f34064
Cr-Commit-Position: refs/heads/master@{#398770}
==========

[commit-bot: I haz the power, 2016-06-09 03:25:23]

Patchset 2 (id:??) landed as
https://crrev.com/b2c4d4e8b507616425a23d6bb5b9df5ff6f34064
Cr-Commit-Position: refs/heads/master@{#398770}