Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4562)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2038403002: Add a new way to record Rappor metrics for MIDI permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: M52 -> M53 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index 43470736f50dabfdb9d9cc31ac9c5d57796321e8..efbdf5f04b6c65ff92efbb88a5fa6d95f2c44fb1 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -195,10 +195,15 @@ void RecordPermissionRequest(PermissionType permission,
rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin));
} else if (permission == PermissionType::MIDI ||
permission == PermissionType::MIDI_SYSEX) {
+ // TODO(dominickn): remove this deprecated metric - crbug.com/605836.
rappor::SampleDomainAndRegistryFromGURL(
rappor_service,
"ContentSettings.PermissionRequested.Midi.Url",
requesting_origin);
+ rappor_service->RecordSample(
+ "ContentSettings.PermissionRequested.Midi.Url2",
+ rappor::LOW_FREQUENCY_ETLD_PLUS_ONE_RAPPOR_TYPE,
+ rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin));
}
}
« no previous file with comments | « no previous file | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698