Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

Issue 2038333002: PaymentRequest: Provide shippingAddress in PaymentResponse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
index 9555b8faf972198f583a9f3e42f82f755841be12..f56bf9b1437e482219089acd0615ce3f56ea4973 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
@@ -5,6 +5,7 @@
#include "modules/payments/PaymentResponse.h"
#include "bindings/core/v8/JSONValuesForV8.h"
+#include "modules/payments/PaymentAddress.h"
#include "modules/payments/PaymentCompleter.h"
#include "wtf/Assertions.h"
@@ -13,9 +14,12 @@ namespace blink {
PaymentResponse::PaymentResponse(mojom::blink::PaymentResponsePtr response, PaymentCompleter* paymentCompleter)
: m_methodName(response->method_name)
, m_stringifiedDetails(response->stringified_details)
+ , m_shippingAddress(nullptr)
please use gerrit instead 2016/06/06 01:09:34 , m_shippingAddress(response->shipping_address ? n
zino 2016/06/06 10:02:13 Done.
, m_paymentCompleter(paymentCompleter)
{
DCHECK(m_paymentCompleter);
+ if (response && response->shipping_address)
please use gerrit instead 2016/06/06 01:09:34 remove this block
zino 2016/06/06 10:02:13 Done.
+ m_shippingAddress = new PaymentAddress(std::move(response->shipping_address));
}
PaymentResponse::~PaymentResponse()
@@ -34,6 +38,7 @@ ScriptPromise PaymentResponse::complete(ScriptState* scriptState, bool success)
DEFINE_TRACE(PaymentResponse)
{
+ visitor->trace(m_shippingAddress);
visitor->trace(m_paymentCompleter);
}

Powered by Google App Engine
This is Rietveld 408576698