third_party/WebKit/Source/modules/payments/PaymentRequest.cpp - Issue 2038333002: PaymentRequest: Provide shippingAddress in PaymentResponse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Issue 2038333002: PaymentRequest: Provide shippingAddress in PaymentResponse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentResponse.h » ('j') | third_party/WebKit/Source/modules/payments/PaymentResponse.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

index b714ad694eba2cfa9da60da2279478a1c7819b21..a2c9d644a6302f2c76d1aab201436b217b763851 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

@@ -435,7 +435,11 @@ void PaymentRequest::OnPaymentResponse(mojom::blink::PaymentResponsePtr response

return;

}

- m_shippingAddress = new PaymentAddress(std::move(response->shipping_address));

+ if (m_options.requestShipping())

please use gerrit instead 2016/06/06 01:09:34 Replace this block with: m_shippingAddress = new

zino 2016/06/06 10:02:13 Done.

+ m_shippingAddress = new PaymentAddress(response->shipping_address->Clone());

+ else

+ m_shippingAddress = new PaymentAddress(std::move(response->shipping_address));

m_shippingOption = response->shipping_option_id;

}