test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden - Issue 2038323002: [interpreter] Filter expression positions at source.

Unified Diff: test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden

Issue 2038323002: [interpreter] Filter expression positions at source. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0060-source-position-testing

Patch Set: Fix expression positions on StackCheck that this CL broke. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/interpreter/bytecode-array-builder.h ('K') | « test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden ('k') | test/cctest/interpreter/bytecode_expectations/OuterContextVariables.golden » ('j') | test/cctest/interpreter/test-source-positions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden b/test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden

index 58f6093d5404db9a4b7d436bbfd0651804529458..2f4bd053825f7116b48b44d3cd378e2c152a9a31 100644

--- a/test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden

+++ b/test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden

@@ -58,8 +58,8 @@ bytecodes: [

B(Star), R(0),

/* 45 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(1),

B(Star), R(1),

- /* 75 E> */ B(Ldar), R(0),

- B(StaNamedPropertySloppy), R(1), U8(1), U8(1),

+ B(Ldar), R(0),

+ /* 75 E> */ B(StaNamedPropertySloppy), R(1), U8(1), U8(1),

B(Ldar), R(1),

/* 80 S> */ B(Return),

]

@@ -76,16 +76,15 @@ snippet: "

frame size: 2

parameter count: 1

-bytecode array length: 23

+bytecode array length: 22

bytecodes: [

/* 30 E> */ B(StackCheck),

/* 42 S> */ B(LdaSmi), U8(1),

B(Star), R(0),

/* 45 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(1),

B(Star), R(1),

- /* 59 E> */ B(Nop),

- /* 67 E> */ B(LdaSmi), U8(1),

- B(Add), R(0),

+ B(LdaSmi), U8(1),

+ /* 67 E> */ B(Add), R(0),

B(StaNamedPropertySloppy), R(1), U8(1), U8(1),

B(Ldar), R(1),

/* 76 S> */ B(Return),

@@ -257,11 +256,11 @@ bytecodes: [

B(Star), R(1),

B(LdaSmi), U8(1),

B(Star), R(3),

- /* 57 E> */ B(LdaZero),

+ B(LdaZero),

B(Star), R(5),

B(Mov), R(1), R(2),

B(Mov), R(0), R(4),

- B(CallRuntime), U16(Runtime::kSetProperty), R(2), U8(4),

+ /* 57 E> */ B(CallRuntime), U16(Runtime::kSetProperty), R(2), U8(4),

B(Ldar), R(1),

/* 62 S> */ B(Return),

]

@@ -308,8 +307,8 @@ bytecodes: [

B(Star), R(0),

/* 50 S> */ B(CreateObjectLiteral), U8(1), U8(0), U8(35),

B(Star), R(1),

- /* 60 E> */ B(Ldar), R(0),

- B(ToName),

+ B(Ldar), R(0),

+ /* 60 E> */ B(ToName),

B(Star), R(3),

B(LdaSmi), U8(1),

B(Star), R(4),

@@ -342,8 +341,8 @@ bytecodes: [

B(Star), R(0),

/* 50 S> */ B(CreateObjectLiteral), U8(1), U8(0), U8(1),

B(Star), R(1),

- /* 64 E> */ B(Ldar), R(0),

- B(StaNamedPropertySloppy), R(1), U8(2), U8(1),

+ B(Ldar), R(0),

+ /* 64 E> */ B(StaNamedPropertySloppy), R(1), U8(2), U8(1),

/* 68 E> */ B(ToName),

B(Star), R(3),

B(LdaSmi), U8(1),

@@ -378,8 +377,8 @@ bytecodes: [

B(Star), R(0),

/* 50 S> */ B(CreateObjectLiteral), U8(1), U8(1), U8(35),

B(Star), R(1),

- /* 60 E> */ B(Ldar), R(0),

- B(ToName),

+ B(Ldar), R(0),

+ /* 60 E> */ B(ToName),

B(Star), R(3),

B(LdaSmi), U8(1),

B(Star), R(4),

@@ -417,8 +416,8 @@ bytecodes: [

B(Star), R(0),

/* 50 S> */ B(CreateObjectLiteral), U8(1), U8(0), U8(35),

B(Star), R(1),

- /* 60 E> */ B(Ldar), R(0),

- B(ToName),

+ B(Ldar), R(0),

+ /* 60 E> */ B(ToName),

B(Star), R(3),

B(LdaConstant), U8(2),

B(Star), R(4),